Skip to content

fix flaky seed write in the hashmap scenarios test #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerardrecinto merged 1 commit into from
Oct 20, 2026
Merged

fix flaky seed write in the hashmap scenarios test #611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions fs/hashmap_scenarios_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,17 +274,13 @@ func TestHashmap_AllScenarios(t *testing.T) {

// --- Scenario: write error in updateFileBlockRegion (err != nil branch) ---
// Covered separately from partial write above which exercises (err == nil && n != blockSize).
dioWriteErr := newFileDirectIO()
segFileWE := filepath.Join(base, "writeerr-seg.reg")
if err := dioWriteErr.open(ctx, segFileWE, os.O_CREATE|os.O_RDWR, permission); err != nil {
t.Fatalf("open seg: %v", err)
// Seed a full block so read succeeds (avoids partial read branch). A plain
// file write is used because direct I/O rejects unaligned buffers with
// EINVAL, and Go does not align a make([]byte) allocation.
if err := os.WriteFile(segFileWE, make([]byte, blockSize), permission); err != nil {
t.Fatalf("seed full block: %v", err)
}
// Seed a full block so read succeeds (avoids partial read branch).
seed := make([]byte, blockSize)
if n, err := dioWriteErr.file.WriteAt(seed, 0); err != nil || n != blockSize {
t.Fatalf("seed full block: n=%d err=%v", n, err)
}
dioWriteErr.file.Close()
dioRO := newFileDirectIO()
if err := dioRO.open(ctx, segFileWE, os.O_RDONLY, permission); err != nil {
t.Fatalf("ro open: %v", err)
Expand Down
Loading