Repository navigation
fix flaky seed write in the hashmap scenarios test - #611
Merged
Merged
Conversation
Direct I/O rejects unaligned buffers with EINVAL, so the seed write failed whenever the allocator returned an unaligned slice. Seed with a plain file write.
gerardrecinto
enabled auto-merge (squash)
October 20, 2026 01:57
Gemini PR ReviewReviewed commit: No actionable findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestHashmap_AllScenarios failed intermittently in CI with
seed full block: write ...: invalid argument. The seed used a direct I/O file with an unalignedmake([]byte)buffer, which fails with EINVAL depending on allocation. Seed with a plain file write instead. Seen on #610, which only touches HTML.Thanks,
Gerard Recinto