Repository navigation
Publish releases for multi-digit version numbers - #1088
Merged
Merged
Conversation
mauroservienti
enabled auto-merge (squash)
November 1, 2026 16:39
…so tags such as 5.2.10 or 10.0.0 published nothing. The stable tag check was unanchored and unescaped, so a pre-release tag ending in three numbers, such as 1.0.0-alpha.1.2.3, would have been published to NuGet.org as stable. Publish releases for multi-digit version numbers
mauroservienti
force-pushed
the
fix-ci-tag-filters
branch
from
November 1, 2026 16:40
294cb7a to
4a5b2e6
Compare
This was referenced Nov 1, 2026
mauroservienti
added a commit
that referenced
this pull request
Nov 1, 2026
…so tags such as 5.2.10 or 10.0.0 published nothing. The stable tag check was unanchored and unescaped, so a pre-release tag ending in three numbers, such as 1.0.0-alpha.1.2.3, would have been published to NuGet.org as stable. (#1088) (#1090) Publish releases for multi-digit version numbers (cherry picked from commit 48b62df)
mauroservienti
added a commit
that referenced
this pull request
Nov 1, 2026
…so tags such as 5.2.10 or 10.0.0 published nothing. The stable tag check was unanchored and unescaped, so a pre-release tag ending in three numbers, such as 1.0.0-alpha.1.2.3, would have been published to NuGet.org as stable. (#1088) (#1091) Publish releases for multi-digit version numbers (cherry picked from commit 48b62df)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI tag filters didn't match every version:
5.0.1010.0.010.0.0-beta.1The stable tag check,
[0-9]+.[0-9]+.[0-9]+$, is now anchored and escaped. Unanchored, a pre-release tag ending in three numbers, such as1.0.0-alpha.1.2.3, would have been published to NuGet.org as a stable release.Tag builds use the workflow at the tagged commit, so
release-5.2andrelease-4.3need the same fix, cherry-picked once this is merged.