Bound native input diagnostics and pending-host teardown - #185
Merged
wieslawsoltes merged 1 commit intoSep 16, 2026
Merged
wieslawsoltes merged 1 commit into
wieslawsoltes merged 1 commit into
Conversation
wieslawsoltes
added this pull request to stack #186
September 16, 2026 21:09
wieslawsoltes
marked this pull request as ready for review
September 16, 2026 21:12
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
Native clipboard requests may still own V8 persistent resolver and file handles when a window closes. Releasing those members after isolate disposal can crash the native worker. At the same time, reproducing an input crash requires symbols for the exact packaged macOS runtime and a bounded stress path that covers pointer/focus state and legacy clipboard completion.
This layer clears pending host-promise and file targets while the isolate lock is still held, before the context and isolate are disposed. It also emits a dSYM from the exact macOS Release runtime and strips the shipped binary afterward, so diagnostics add no normal-path runtime or installed-package cost.
Dependency and issue mapping
4b61f2102c6aa987045d5d3ddd4b0ceb973bf909.537d2fb9c0ab7553ec27b028dc236dd893b53f4f.Scope and bounds
dsymutil; the packaged native runtime is stripped after symbol extraction.input-diagnostics-pointer-focusnative filter covers 10,000 focus transitions, 10,000 trusted Meta-C clipboard inputs/completions, and destruction with a pending host promise.Validation
git diff --checkpass.Stack
This is the cumulative top of the native desktop capability stack. Only its changed-behavior native document and precompiled/V8 gates qualify the atomic stack merge. Draft consolidation PR #76 remains open and unmerged.