Release pending host handles before V8 teardown - #140
Closed
wieslawsoltes wants to merge 1 commit into
Closed
wieslawsoltes wants to merge 1 commit into
wieslawsoltes wants to merge 1 commit into
Conversation
Collaborator
Author
|
Closing this older isolated review as superseded by merged native Stack #186. The pending-host-handle teardown fix and its direct regression are included in focused PRs #184/#185 on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Destroying an engine with an unfinished clipboard/file host request disposed V8 before persistent contexts and promise resolvers were released. The public-ABI reproducer and packaged Code OSS crash shared all eight WebScene frames and exited 139 before the fix.
Change
Clear
host_promise_targetsandfile_targetsunder the isolate lock before context/isolate disposal. Add the direct pending-request teardown regression while preserving the 10,000 completed-copy stress and symbolized package diagnostics.Validation
clean destroyand exits 0.Integration
Closes #89.
Equivalent commit
31e3d8adis already in draft consolidation PR #76. This PR targets the exact diagnostic commit immediately before the runtime fix for isolated review. Keep it open and do not merge it tomain.