Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dist/firetruss.es2015.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/firetruss.es2015.js.map

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions dist/firetruss.umd.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/firetruss.umd.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/firetruss.umd.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/firetruss.umd.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "firetruss",
"version": "8.3.0",
"version": "8.3.1",
"description": "Advanced data sync layer for Firebase and Vue.js",
"scripts": {
"update": "yarn up -R '*' && yarn dedupe --strategy highest",
Expand Down
2 changes: 2 additions & 0 deletions src/Truss.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ export default class Truss {
let connector = new Connector(scope, {result: target}, this._tree, 'peek');

let unintercept = this.intercept('peek', {onFailure: op => {
// A failure callback may already be queued when cleanup removes the interceptor.
if (!connector) return;
function match(descriptor) {
if (!descriptor) return;
if (descriptor instanceof Handle) return op.target.isEqual(descriptor);
Expand Down
42 changes: 42 additions & 0 deletions src/Truss.test.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import {mock, test} from 'node:test';
import assert from 'node:assert/strict';
import _ from 'lodash';

import './Truss.test.setup.js';
import Truss from './Truss.js';
import {Reference} from './Reference.js';


test('wait for remote data updates resolves immediately when none are pending', async () => {
Expand Down Expand Up @@ -42,3 +44,43 @@ test('wait for remote data updates adds a next tick after pending snapshots', as
await promise;
assert.equal(resolved, true);
});


for (const outcome of ['failure', 'success']) {
test(`peek ignores queued failures after ${outcome} cleanup`, async () => {
let onFailure, onReady;
const disconnect = mock.fn();
const unintercept = mock.fn();
const unobserve = mock.fn();
const tree = {connectReference: () => disconnect, getObject: _.constant(42)};
const target = new Reference(tree, '/value');
const truss = {
_tree: tree,
intercept(method, callbacks) {
assert.equal(method, 'peek');
onFailure = callbacks.onFailure;
return unintercept;
},
observe(subject, callback) {onReady = callback; return unobserve;}
};
const promise = Truss.prototype.peek.call(truss, target);
await Promise.resolve();

// Dispatcher snapshots callbacks before deferring their invocation with setTimeout.
const error = new Error('original read failure');
const queuedFailure = () => onFailure({target, error});
if (outcome === 'failure') {
queuedFailure();
await assert.rejects(promise, error);
} else {
onReady(true);
assert.equal(await promise, 42);
}

assert.equal(disconnect.mock.calls.length, 1);
assert.equal(unintercept.mock.calls.length, 1);
assert.equal(unobserve.mock.calls.length, 1);
assert.doesNotThrow(queuedFailure);
assert.equal(disconnect.mock.calls.length, 1);
});
}