Repository navigation
- Fix: ignore queued peek failures after cleanup - #49
Conversation
Sentry investigation contextThe two captures in REVIEWABLEIO-CLIENT-4V4 occurred one second apart on SaaS client build 7950 / Firetruss 8.3.0, during reads of two reviews in the same repository. The event's final identity is unauthenticated, but earlier breadcrumbs identify an authenticated agent followed by an auth refusal and sign-out. The source also screened as residential, so the anonymous data-center archive rule does not apply.
This corrects the secondary lifecycle exception, not the upstream authentication refusal or access failures. Sentry remains unresolved while the library PR is reviewed; production needs publication and consumer adoption before a deployment-based resolution is justified. No authenticated production behavior or credentials were changed. |
pkaminski
left a comment
There was a problem hiding this comment.
@pkaminski reviewed 9 files and all commit messages.
Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on pkaminski).
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
snoack
left a comment
There was a problem hiding this comment.
@snoack reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pkaminski).
When a
peek()has already completed or failed, Dispatcher can still invoke a failure interceptor captured before cleanup. That callback reads the now-null connector and raises a second, unhandledTypeError.Ignore the callback after its connector has been cleaned up. Active peeks still reject with their original read error. Bump Firetruss to 8.3.1 and regenerate the distributed bundles.
Validation: all 81 tests pass, lint passes, and UMD/ES bundles plus source maps regenerate successfully. The two new regression cases reproduce the exact null-
atexception on the previous code after failed and successful peeks, then pass with the guard. They also verify that the original outcome and one-time cleanup are preserved.Fixes REVIEWABLEIO-CLIENT-4V4
Sentry issue · Motivating event
The consuming application must adopt the published library version before this is fixed in production.
This change is