Skip to content

fix: Clarify shared risk-block attention notifications - #769

Merged
Pigbibi merged 2 commits into
mainfrom
fix/risk-block-alert-format
Nov 2, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
fix/risk-block-alert-format

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

AI assistance

Codex, GPT-6.1 Sol. Independent review is pending with the established code-review-and-merge bot.

What changed

Render risk-block alerts with a broker, masked account suffix, strategy, status, reason codes plus localized explanations, optional baseline-loss/limit evidence, SGT run time, a supplied console run link, and one clear action. Unknown facts remain unknown. Remove confusing intent-confirmation wording. Preserve Schwab's equity-baseline semantics.

All display arguments are optional. Existing transition keys, notification routing, admission decisions and switches are unchanged. The companion Schwab draft adopts this shared format after coordinated pin review; no dependency pins change here.

How verified

  • Full offline QPK suite: 3,588 passed, 1,277 subtests passed, 2 skipped; network denied by seccomp.
  • Ruff and documentation checks passed (one existing non-blocking README advisory).
  • Synthetic tests cover seven broker labels, Chinese/English, masking, unknown financial facts, invalid timestamps/URLs, credential/query stripping, stable decisions and transition keys.
  • Paired Schwab full offline suite: 5,081 passed, 403 subtests passed, 1 skipped. Current-pin compatibility subset: 129 passed, 10 subtests, 1 explicit feature-unavailable skip.
  • Initial QPK full run had three source-revision environment failures; rerun supplied the actual base Git SHA and passed. No assertions were weakened to bypass them.

Why

The reported Schwab alert hid its reason code, replaced the account with a generic placeholder and gave confusing guidance without run evidence.

Risk

Presentation-only changes in risk notification paths; protected-path classification remains with repository policy. No risk math, switch, pin, order-planning, workflow or deployment change. Missing real console-run URL production remains NOT_PROVEN: the renderer accepts an actual URL but never invents one. Other consumers require coordinated pin adoption; live delivery and hosted CI are not claimed.

Companion draft: QuantStrategyLab/CharlesSchwabPlatform#670. Review and rollout belong to the established code-review-and-merge bot.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e4a8040c-ccf6-4bcb-b7e6-3c88acd32128
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Keep the original transition key for sending and deduplication.

Cover failure logs, retries, and distinct synthetic accounts.
@Pigbibi Pigbibi added the owner-approved Owner approval for high-risk PRs. AI agents must never apply this label. label Nov 2, 2026
@Pigbibi
Pigbibi marked this pull request as ready for review November 2, 2026 16:08
@Pigbibi
Pigbibi merged commit f6d7352 into main Nov 2, 2026
9 of 11 checks passed
@Pigbibi
Pigbibi deleted the fix/risk-block-alert-format branch November 2, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval for high-risk PRs. AI agents must never apply this label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant