Repository navigation
fix: Clarify shared risk-block attention notifications - #769
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Keep the original transition key for sending and deduplication. Cover failure logs, retries, and distinct synthetic accounts.
Pigbibi
marked this pull request as ready for review
November 2, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Codex, GPT-6.1 Sol. Independent review is pending with the established code-review-and-merge bot.
What changed
Render risk-block alerts with a broker, masked account suffix, strategy, status, reason codes plus localized explanations, optional baseline-loss/limit evidence, SGT run time, a supplied console run link, and one clear action. Unknown facts remain unknown. Remove confusing intent-confirmation wording. Preserve Schwab's equity-baseline semantics.
All display arguments are optional. Existing transition keys, notification routing, admission decisions and switches are unchanged. The companion Schwab draft adopts this shared format after coordinated pin review; no dependency pins change here.
How verified
Why
The reported Schwab alert hid its reason code, replaced the account with a generic placeholder and gave confusing guidance without run evidence.
Risk
Presentation-only changes in risk notification paths; protected-path classification remains with repository policy. No risk math, switch, pin, order-planning, workflow or deployment change. Missing real console-run URL production remains NOT_PROVEN: the renderer accepts an actual URL but never invents one. Other consumers require coordinated pin adoption; live delivery and hosted CI are not claimed.
Companion draft: QuantStrategyLab/CharlesSchwabPlatform#670. Review and rollout belong to the established code-review-and-merge bot.