Skip to content

fix: Delegate Schwab risk-block alerts to the shared renderer - #670

Merged
Pigbibi merged 1 commit into
mainfrom
fix/risk-block-alert-format
Nov 2, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
fix/risk-block-alert-format

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

AI assistance

Codex, GPT-6.1 Sol. Independent review is pending with the established code-review-and-merge bot.

What changed

Delegate attention formatting to QPK's shared renderer when its feature marker is available. Pass actual notification-context started_at and optional console_run_url as display-only evidence. Retain the existing renderer until the coordinated QPK revision is adopted, so the current pin continues delivering notifications.

The shared format shows a masked account suffix, reason codes with Chinese/English explanations, optional baseline-loss evidence, SGT run time, a supplied run link and one clear action. Schwab's equity-baseline explanation remains accurate. All existing fallback-renderer assertions remain intact.

How verified

  • Paired QPK/Schwab full offline suite: 5,081 passed, 403 subtests passed, 1 skipped; network denied by seccomp.
  • Current exact QPK pin compatibility: 129 passed, 10 subtests passed, 1 explicit skip for the unavailable new shared feature.
  • Final renderer/fallback subset: 20 passed. Full-repository ruff in the existing Schwab test environment passed; documentation check passed with one existing README advisory.
  • The first full-suite attempt lacked the Schwab SDK. Reusing the existing Schwab test environment resolved collection; no production dependencies changed.

Why

Schwab's local four-line renderer discarded shared reason codes and reduced unknown account mappings to a generic account placeholder. It must adopt the shared format for the owner's requested redesign to reach this broker.

Risk

No risk decisions, switches, pins, routing, approved-gate classification, receipt acceptance, deduplication or deployments change. Until the QPK pin is coordinated, the old format remains active. The current report producer does not provide a verified single-run console URL, and the inspected console routes select accounts rather than individual runs; that end-to-end link remains NOT_PROVEN. No live delivery or hosted CI result is claimed.

Companion draft: QuantStrategyLab/QuantPlatformKit#769. Review and rollout belong to the established code-review-and-merge bot.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47c8cabe-31e7-4245-9c49-e118d6086a28
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pigbibi Pigbibi added the owner-approved Owner approval; review bot may apply on owner's authorization, ledgered label Nov 2, 2026
@Pigbibi
Pigbibi marked this pull request as ready for review November 2, 2026 16:08
@Pigbibi
Pigbibi merged commit 7d4d29a into main Nov 2, 2026
13 of 14 checks passed
@Pigbibi
Pigbibi deleted the fix/risk-block-alert-format branch November 2, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval; review bot may apply on owner's authorization, ledgered

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant