Repository navigation
fix: Delegate Schwab risk-block alerts to the shared renderer - #670
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Pigbibi
marked this pull request as ready for review
November 2, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Codex, GPT-6.1 Sol. Independent review is pending with the established code-review-and-merge bot.
What changed
Delegate attention formatting to QPK's shared renderer when its feature marker is available. Pass actual notification-context
started_atand optionalconsole_run_urlas display-only evidence. Retain the existing renderer until the coordinated QPK revision is adopted, so the current pin continues delivering notifications.The shared format shows a masked account suffix, reason codes with Chinese/English explanations, optional baseline-loss evidence, SGT run time, a supplied run link and one clear action. Schwab's equity-baseline explanation remains accurate. All existing fallback-renderer assertions remain intact.
How verified
Why
Schwab's local four-line renderer discarded shared reason codes and reduced unknown account mappings to a generic account placeholder. It must adopt the shared format for the owner's requested redesign to reach this broker.
Risk
No risk decisions, switches, pins, routing, approved-gate classification, receipt acceptance, deduplication or deployments change. Until the QPK pin is coordinated, the old format remains active. The current report producer does not provide a verified single-run console URL, and the inspected console routes select accounts rather than individual runs; that end-to-end link remains NOT_PROVEN. No live delivery or hosted CI result is claimed.
Companion draft: QuantStrategyLab/QuantPlatformKit#769. Review and rollout belong to the established code-review-and-merge bot.