Repository navigation
feat: Add a paper-only plain-DCA preview consumer - #708
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review Owner t1270u requests an exact-head review after syncing current main. Scope: Phase 1 preview-only adapter; longbridge-paper only; reject SG/HK; LIVE/Kelly/all stop-loss switches OFF. No PAPER start, deploy, scheduler enablement, Secrets/IAM, DEFAULT_SPEC changes or #707 work. Please bind the receipt to the current full head. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b139f4277
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
AI assistance
Codex (host-configured GPT-6 model; exact variant unavailable).
What changed
Add an explicit Phase 1 consumer for the UES plain-DCA preview contract. Accept only the resolved paper target in the longbridge-paper Environment, verify current protected PAPER binding and OFF safety evidence, and reject SG/HK, stale evidence and reader failure before the planner runs. Keep all preview-only flags. Add regression tests and document the protected-reader contract.
How verified
Why
LongBridge has no scoped consumer of evaluate_dca_period. The sole approved PAPER environment must be enforced independently of dry-run labels before this preview interface can be integrated.
Risk
Execution-admission code requires the established review bot's disposition. No workflow, route, scheduler, registry, dependency pin or order writer is changed. The installed UES pin lacks plain_dca and therefore fails closed with plain_dca_api_unavailable. This Draft does not claim deployed adoption or broker account isolation. Authentic protected reader, compatible reviewed UES pin, isolated state/credentials, setup and durable execution evidence remain prerequisites. No Phase 2, deployment, broker submission, cloud mutation, notification, protected switch or Draft #707 operation occurred.
Read-only configuration finding: the PAPER Environment has LONGBRIDGE_DRY_RUN_ONLY=false. The shared contract requires false for explicit execution_environment=paper; legacy execution_mode=live is insufficient by itself to establish broker mode. Configuration metadata does not establish who set the value or deployed safety. No value was changed.
Publication check
Central checker publication-check/2.0-advisory, build 83d9d1130377: advisory; 1451 matching lines / 1462 findings across the complete tracked candidate tree. The report is advisory, not an approval. First 20 matches below are masked inherited source references; new additions are scanned separately.