Skip to content

fix: Preserve execution evidence after heartbeat failures - #682

Open
Pigbibi wants to merge 1 commit into
mainfrom
fix/preserve-heartbeat-execution-evidence
Open

Pigbibi wants to merge 1 commit into
mainfrom
fix/preserve-heartbeat-execution-evidence

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

AI assistance

Implemented with OpenAI Codex (GPT-6). Independent review is provided by the repository's configured Codex integration on the published head.

What changed

Keep the existing read-only execution-evidence export eligible after a failed heartbeat or completed-window candidate check. It now requires a non-cancelled job, installed runtime dependencies, and successful primary or retry authentication. Preserve the preceding failures, the action pin, credentials scope, schedules and all execution protections.

How verified

25 focused workflow tests passed; Ruff passed; documentation check reported 0 blocking findings and 1 pre-existing advisory; actionlint passed; git diff --check passed. Gitleaks 8.30.1 on origin/main..HEAD: exit 0, 0 findings. The central publication-check script was not available on this host; no central-checker result is claimed. No workflow was dispatched and no cloud deployment or runtime action was performed.

Why

The export previously inherited GitHub Actions' implicit success() condition. A missing receipt or candidate conflict therefore skipped the independent archived-evidence export and created a second visibility gap.

Risk

Workflow control flow only. Existing evidence reads and sync inputs remain unchanged. Failed authentication, failed installation and cancellation still prevent export. This source change does not reconcile conflicting candidates or prove broker execution, delivery or production recovery.

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review exact head 834ab22198b377cea91abf8a8b20f7e08ecf2a55 against base 4464279692ae9901e284631ea73785dbd8510718. Scope: the three-file workflow fix and offline regression only. Verify that failed heartbeat/candidate checks no longer suppress independent archived execution-evidence export, while cancellation, failed dependency installation and unsuccessful authentication still prevent it. No production dispatch or deployment is authorized. Focused tests and source verification are recorded in the PR body.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T05:13:40.911397Z 834ab22 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 834ab22198

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 6, 2026 — with ChatGPT Codex Connector
@Pigbibi
Pigbibi marked this pull request as ready for review November 6, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant