Repository navigation
ci: Add clearing-label recorder diagnostics - #684
Merged
Merged
Conversation
This was referenced Nov 6, 2026
Collaborator
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pigbibi
marked this pull request as ready for review
November 6, 2026 14:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Implemented with OpenAI Codex (GPT-6). A separate read-only AI reviewer inspected the complete two-file change against base
4464279692ae9901e284631ea73785dbd8510718. Its sole finding about an ambiguous status-write response was corrected and rechecked; no material findings remain. This local review does not substitute for the repository's current-head review receipt.What changed
Add fixed reason codes to each clearing-label recorder no-op and explicit warnings when an expected clearing label cannot produce a status. At event matching, log only the payload timestamp, authorized candidate-event timestamps, exact match count, and head/PR equality booleans. Preserve API failures; report an unconfirmed status-write outcome without retrying.
Acceptance semantics are unchanged: observability only. The existing sender, open-PR, payload head/number, event actor/label, unique exact timestamp match, and status binding remain intact. The evaluator, including revocation checks, is byte-for-byte unchanged. No timestamp window, latest-event fallback, or approval bypass is introduced.
How verified
Why
A prior recorder run for #682 completed without a clearing-label record and without identifying its early-return path. These diagnostics provide evidence for the next natural label delivery. They do not establish the original cause or fix clearing-label acceptance.
Risk
High: trusted workflow path. Only the recorder and its existing workflow-test file change. The equality fields are diagnostics, not new gates: head equality compares the payload head with context.sha (which can be the base SHA for pull_request_target); PR equality compares the payload number with context.issue.number. No tokens, keys, full payloads or account secrets are logged.
Keep this PR as a Draft. #682 and #683 remain untouched. No approval label, undraft, merge, status fabrication, deployment or production action is authorized by this change.