Skip to content

ci: Add clearing-label recorder diagnostics - #684

Merged
Pigbibi merged 1 commit into
mainfrom
ci/clearing-label-recorder-diagnostics
Nov 6, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
ci/clearing-label-recorder-diagnostics

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

AI assistance

Implemented with OpenAI Codex (GPT-6). A separate read-only AI reviewer inspected the complete two-file change against base 4464279692ae9901e284631ea73785dbd8510718. Its sole finding about an ambiguous status-write response was corrected and rechecked; no material findings remain. This local review does not substitute for the repository's current-head review receipt.

What changed

Add fixed reason codes to each clearing-label recorder no-op and explicit warnings when an expected clearing label cannot produce a status. At event matching, log only the payload timestamp, authorized candidate-event timestamps, exact match count, and head/PR equality booleans. Preserve API failures; report an unconfirmed status-write outcome without retrying.

Acceptance semantics are unchanged: observability only. The existing sender, open-PR, payload head/number, event actor/label, unique exact timestamp match, and status binding remain intact. The evaluator, including revocation checks, is byte-for-byte unchanged. No timestamp window, latest-event fallback, or approval bypass is introduced.

How verified

  • 8 focused unittest methods passed, including existing Dependabot cases and recorder fixtures for all no-op reasons, exact timestamp mismatch, duplicate events, wrong actor/label/event, payload-head/PR/event binding, and API failure before/after a write.
  • Ruff, actionlint and git diff --check passed.
  • Documentation check: 0 blocking findings; 1 existing README outline advisory.
  • Gitleaks 8.30.1: exit 0, 0 findings on the local two-file commit range from the stated base. The published Git tree is identical to that tested and scanned tree.
  • Compared workflow sections: triggers, permissions, action pin, environment, evaluator, exact event predicate and status payload are preserved.
  • The full runtime suite and live label event were not run; no workflow dispatch was performed.

Why

A prior recorder run for #682 completed without a clearing-label record and without identifying its early-return path. These diagnostics provide evidence for the next natural label delivery. They do not establish the original cause or fix clearing-label acceptance.

Risk

High: trusted workflow path. Only the recorder and its existing workflow-test file change. The equality fields are diagnostics, not new gates: head equality compares the payload head with context.sha (which can be the base SHA for pull_request_target); PR equality compares the payload number with context.issue.number. No tokens, keys, full payloads or account secrets are logged.

Keep this PR as a Draft. #682 and #683 remain untouched. No approval label, undraft, merge, status fabrication, deployment or production action is authorized by this change.

@Pigbibi

Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review
Please review the exact current head 272ea54 and publish the codex-review-state:v1 receipt. This is a diagnostics-only recorder change; no deploy or relabel of other PRs.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T15:00:33.213086Z 272ea54 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Pigbibi
Pigbibi marked this pull request as ready for review November 6, 2026 14:59
@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 6, 2026
@Pigbibi
Pigbibi merged commit da8f703 into main Nov 6, 2026
15 of 17 checks passed
@Pigbibi
Pigbibi deleted the ci/clearing-label-recorder-diagnostics branch November 6, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant