Repository navigation
Conversation
caldav 3.6 reads the config file through calendaring-config, so a plann section can use kind: caldav with plain keys, password_command and password_keyring. caldav runs a password_command only after checking the file it came from, so plann now passes its config file along to extract_conn_params_from_section(), with ~ expanded. A failing password_command skips the section with an error message, unless --raise-errors. caldav 3.6 is required for that parameter. python-caldav/caldav#786 Prompt: fix (the issue found in) plann, lift the cladav (sic) floor to 3.6, open a PR Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
plann no longer hard-codes ~/.config/calendar.conf: without -c it uses the first file on the search path shared with caldav and other tools (calendaring-config decides it, ~/.config/pycal/calendar.yaml first), and configure saves at the head of that path when the file it read is not writable (/etc), creating it readable by its owner only. The file is looked up only when it is read, so --help and --skip-config work whatever CALDAV_CONFIG_FILE says. Config errors name their section. python-caldav/caldav#786 Prompt: The shared search path defined in calendaring-config should be used, we should have no hard-coded search path in the plann library. Open the PR. Followup-Prompt: (...) I think it should be safe to go ahead and fix calendaring-config [the section names in errors were added by a parallel session, from a review finding] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
changed the title
tobixen
added a commit
to python-caldav/caldav
that referenced
this pull request
Oct 20, 2026
#809 gave extract_conn_params_from_section() its section_name, and plann passes it in PyCalendar/plann#81, so nothing is left of the entry. Prompt: [fix issues found during the review process of merging #808] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: AI-generated code and text below the line, generated by Claude Opus 5.5, from the prompts:
caldav 3.6 reads its config file through calendaring-config, and plann now follows it all the way (python-caldav/caldav#786):
kind: caldavwith plain keys,password_commandandpassword_keyring. plann passes its config file to caldav, which runs a command only from a file nobody else can write to. A failing command skips that section with an error, unless--raise-errors.~/.config/calendar.confany more: without-c, plann uses the first file on the shared search path (~/.config/pycal/calendar.yamlfirst), andCALENDARING_CONFIG_FILE/CALDAV_CONFIG_FILEapply.plann configurecreates~/.config/pycal/calendar.yamlwhen there is none, or when the file it found is not writable, readable by its owner only.Requires caldav 3.6 and calendaring-config 0.4, neither released yet, so CI stays red until then; the section names also need caldav's
section-name-in-errorschange.