Repository navigation
fix(programs): role actions and shared UI for program solutions - #511
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Program solution pages added duplicate actions, lost the existing Office/program header on navigation and used controls outside the shared UI kit. Keep signed-in public solutions inside the existing program layout and reuse the canonical Tabs, Search, Avatar, Card, State, typography and form controls throughout solution editing, team and evaluation screens.
Organizers keep the management action; experts get one works-list action in its existing position. For visitors who have not joined the program, public works replace the disabled more placeholder, preserving the action row and registration priority. Missing registration links are explained without changing program settings. Finished legacy programs use the paired backend's read-only published-projects reader; manager routes and private lists remain intact. Empty advertisement URLs no longer render broken images.
Validation: the exact PR commit 44bab2e passed all 3,042 tests / 493 files, strict C00 contract verification, full Prettier check, TypeScript lint (0 errors, 6 existing warnings) and development build. Checks ran from a Git snapshot with LF line endings, matching CI source rather than Windows checkout conversion. Changed styles passed stylelint. Real compiled Angular was checked with synthetic local API fixtures for organizer, expert and participant actions, preserved header geometry, public materials/team and widths 320/390/768/1440. Live-dev acceptance follows deployment.
Requires PROCOLLAB-github/api#836 deployed first. Existing programs are not migrated and program settings/data are unchanged.