Repository navigation
fix(programs): use the shared modal scroll container for solution dialogs - #512
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live acceptance of #511 showed nested scrollbars in the solution case-change dialog at a 914px viewport: its inner section overflowed by 1px in both directions, although the shared Modal already limits height and handles scrolling.
Remove the inner section's max-height and overflow so the existing Modal owns scrolling. This affects only the new solution-management dialogs; no global modal styles, legacy pages, API or data changes.
Validation: 13 solution-application/case-dialog tests passed, stylelint and Prettier passed, full commit-hook lint passed with six existing warnings, and the development build passed. Repeat the live dialog check after deployment.