Repository navigation
fix(xmlreader): bound reads for truncated BOM prefixes - #2667
Merged
Merged
Conversation
thorstendb-ARM
marked this pull request as ready for review
October 22, 2026 12:12
Test Results 4 files - 36 40 suites - 86 40s ⏱️ - 12m 52s Results for commit d76916e. ± Comparison against base commit 5f04db7. This pull request removes 1269 tests.♻️ This comment has been updated with latest results. |
5 tasks done
edriouk
approved these changes
Oct 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2667 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 207 207
Lines 33545 33545
=======================================
Hits 29336 29336
Misses 4209 4209
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
XML_Reader::CheckUTF()could read beyond the string terminator for truncated BOMprefixes (
EF,FE,FF,EF BB) and report retained bytes asM412.Bound byte consumption to the input length, preserving the
switchstructure andexisting diagnostics for complete inputs.
Validation
On macOS arm64 Debug, the new regression failed on the original code for all four
truncated prefixes. After the change, all 14 tests across XmlReader, XmlTree and
XmlTreeSlim passed, including 17 cases for existing BOM and diagnostic behavior.
Checklist