Repository navigation
chore(codeql): honor XML reader switch annotations - #2668
Merged
Merged
Conversation
thorstendb-ARM
marked this pull request as ready for review
October 22, 2026 12:23
Test Results 5 files - 40 39 suites - 126 3m 38s ⏱️ - 10m 30s Results for commit 2cd6f3e. ± Comparison against base commit b6a936c. This pull request removes 1550 tests.♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 207 207
Lines 33545 33545
=======================================
Hits 29336 29336
Misses 4209 4209
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
edriouk
approved these changes
Oct 22, 2026
soumeh01
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Document the four intentional single-case BOM switches with
codeql[cpp/trivial-switch]comments and an extensibility rationale.Extend the existing SARIF upload filter to honor accepted source suppressions
only for this rule in
libs/xmlreader/src/XML_Reader.cpp.Related to #2667.
Validation
Workflow YAML and 45 synthetic filter cases passed. Existing main SARIF output
remains unchanged; simulated annotations remove exactly the four intended findings.
Confirmation by a CodeQL run is pending.
Checklist