Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sdm/_memory.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@
import os

import torch
from torch.fx.experimental.symbolic_shapes import statically_known_true


def _split_tensor(
tensor: torch.Tensor, size: int, dim: int
) -> tuple[torch.Tensor, ...]:
"""Return one chunk when the dimension provably fits the split size."""
if statically_known_true(tensor.size(dim) <= size):
Comment thread
aw471 marked this conversation as resolved.
Resolved
return (tensor,)
return tensor.split(size, dim=dim)


def set_pinned_max_round_threshold(
Expand Down
8 changes: 4 additions & 4 deletions sdm/processing/numerical/rank_gaussian.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from torch import Tensor

from sdm import Stype, TableTensor
from sdm._memory import split_size
from sdm._memory import _split_tensor, split_size
from sdm.processing import Processor
from sdm.processing.numerical._stats import _isfinite, _ndtri
from sdm.processing.numerical.quantile import _batched_interp
Expand Down Expand Up @@ -62,7 +62,7 @@ def _fit(
device=numerical.device,
)
knots = []
for chunk in numerical.split(size, dim=-1):
for chunk in _split_tensor(numerical, size, dim=-1):
num_rows = chunk.size(-2)
max_knots = num_rows if self.max_knots is None else self.max_knots
columns = chunk.to(dtype).movedim(-1, -2) # [..., C, N]
Expand Down Expand Up @@ -152,8 +152,8 @@ def _transform(self, table: TableTensor) -> TableTensor:
device=numerical.device,
)
for rows, out in zip(
columns.split(size, dim=-1),
output.split(size, dim=-2),
_split_tensor(columns, size, dim=-1),
_split_tensor(output, size, dim=-2),
strict=True,
):
quantiles = _batched_interp(
Expand Down
4 changes: 2 additions & 2 deletions sdm/processing/numerical/robust_scale.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from torch import Tensor

from sdm import Stype, TableTensor
from sdm._memory import split_size
from sdm._memory import _split_tensor, split_size
from sdm.processing import InvertibleMixin, Processor
from sdm.processing.numerical._stats import _isfinite

Expand Down Expand Up @@ -69,7 +69,7 @@ def _fit(
lower, median, upper = torch.cat(
[
chunk.nanquantile(q, dim=-2, keepdim=True)
for chunk in quantile_input.split(size, dim=-1)
for chunk in _split_tensor(quantile_input, size, dim=-1)
],
dim=-1,
)
Expand Down
Loading