Repository navigation
Keep the discovery tests off the test machine's own network - #225
Conversation
The discovery tests inject packets from 192.0.2.x, the documentation range of RFC 5737, so a test machine on 192.168.1.x no longer lists one of them as itself. **Tests** - unit_DevicesModule_discovery: every injected and expected address moves from 192.168.1.x to 192.0.2.x, the same last octet. - test_desktop: 2,875 passed on macOS and the Pi 5 (whole branch). **Docs/CI** - check_prose: NegatedHeading 6 to 8 and SelfReference 16 to 17 are main's baseline: the committed tree measures the same with this change absent. **Reviews** - none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the discovery-fixture address update.
No open issues 🎉
What changed in this PR
Moves discovery test fixtures to RFC 5737’s documentation address range, avoiding the collision with the test machine’s 192.168.1.x address reported in #224. Production behavior is unchanged.
Changes:
- Replaces
192.168.1.xfixture addresses and expected results with192.0.2.x, preserving each last octet. - Updates helper comments to explain the address range and its purpose.
| File | Description |
|---|---|
test/unit/core/unit_DevicesModule_discovery.cpp |
Updates injected packets, restored fixtures, lookup expectations, and comments to use documentation-range addresses. |
Review effort: Balanced
|
Merged, thanks James! Test addresses from RFC 5737's documentation range are exactly the textbook fix: no test machine can hold one. |
NdiDriver.h takes #227's per-light read by role. panel-cards.md and 06-advanced.yaml keep this branch's numbering, where "8. Set the card up in LEDVision" puts "When the wall stays dark" at 9. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The discovery tests inject packets from 192.0.2.x, the documentation range of RFC 5737, so a test machine on 192.168.1.x no longer lists one of them as itself.
Tests
Docs/CI
Reviews
What an agent wrote: Claude Code (Opus) wrote the code, the tests and this text from my direction; I reviewed every line and vouch for it.
Tested: On this branch on macOS, all 2849 desktop tests pass. On main, the same Mac fails "distinct devices don't cross-contaminate name or type", since it holds 192.168.1.186, the address that test injects a WLED from (#224 records it).
check_coderan on this branch before the push.Skipped checks:
🤖 Generated with Claude Code