[AnjinMeili]

A rebuild that prepares the effect again without a release reported its own ports as in use and stopped receiving. It now closes its three sockets before binding them.

Light domain

• NetworkReceiveEffect.h: prepare() closes the Art-Net, E1.31 and DDP sockets before opening and binding them.

Tests

• unit_NetworkReceiveEffect_protocols: binds its ports again on a second prepare.
• Scenarios skipped: no per-frame change for an RGB wiring; NetworkReceive changed only in prepare.

Docs/CI

• check_prose: NegatedHeading 6 to 8 and SelfReference 16 to 17 are main's baseline: the committed tree measures the same with this change absent.

Reviews

• none

What an agent wrote: Claude Code (Opus) wrote the code, the tests and this text from my direction; I reviewed every line and vouch for it.

Tested: On this branch on macOS, 2849 of 2850 desktop tests pass, the new test among them; the one failure is main's discovery test injecting a WLED from 192.168.1.186, which this Mac holds, the bug #225 fixes. Found on a Raspberry Pi 5, where a rebuild left the receiver reporting its own ports in use. check_code ran on this branch before the push.

Skipped checks:

• collect_kpi skipped: the change runs in prepare(), never per frame.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: MoonModules/MoonLight
• Branch: main
• File: .coderabbit.yaml
• Commit: 4e653f4
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 2dea11ab-d8b1-4071-90e7-8aab95789921

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[Copilot]

🟢 Approval recommended

There are no active review issues for the change addressing reception loss after repeated prepare() calls.

No open issues 🎉

What changed in this PR

Fixes NetworkReceive stopping reception when a rebuild calls prepare() twice without an intervening release.

Changes:

• Closes the Art-Net, E1.31, and DDP sockets before reopening and binding them.
• Adds a regression test checking that a second prepare() succeeds without reporting a bind error.

File	Description
test/​unit/​light/​unit_NetworkReceiveEffect_protocols.cpp	Adds a repeated-prepare regression test using a heap-allocated rig.
src/​light/​effects/​NetworkReceiveEffect.h	Closes all three receive sockets before rebinding during preparation.

_{Review effort: Balanced}

[ewowi]

Merged, thanks James! Closing before binding is the right fix, closing an unopened socket is safe on all three platforms, and the test pins the second prepare.