Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ MobilityDuck is the DuckDB extension for MEOS-stored mobility data. Contribution

Please open an issue at https://github.com/MobilityDB/MobilityDuck/issues with:

- The MobilityDuck / MEOS / DuckDB versions you are running. Run `SELECT mobilityduck_full_version();` from the DuckDB shell — it returns the extension version, the linked MEOS commit, the DuckDB version, and the full toolchain.
- The MobilityDuck / MEOS / DuckDB versions you are running. Run `SELECT mobilityduckFullVersion();` from the DuckDB shell — it returns the extension version, the linked MEOS commit, the DuckDB version, and the full toolchain.
- The function signature or SQL query you tried.
- The expected behaviour (typically what MobilityDB on PostgreSQL does for the same input — [`doc/PARITY.md`](doc/PARITY.md) is the reference for *"should work the same"*).
- The actual behaviour, including any error messages.
Expand Down
2 changes: 1 addition & 1 deletion doc/PARITY-INVENTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ shape MobilityDuck uses for `frechetDistancePath` /

## Reporting a gap

Run `mobilityduck_full_version()` from the SQL shell to get the
Run `mobilityduckFullVersion()` from the SQL shell to get the
extension version, the linked MEOS commit, the DuckDB version, and
the full toolchain. If you spot a missing function or unexpected
behaviour, please open an issue with that version line and the
Expand Down
6 changes: 3 additions & 3 deletions doc/PARITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ same rows ordered by time.

| MobilityDB | MobilityDuck |
|---|---|
| `mobilitydb_version()` | `mobilityduck_version()` |
| `mobilitydb_full_version()` | `mobilityduck_full_version()` |
| `mobilitydbVersion()` | `mobilityduckVersion()` |
| `mobilitydbFullVersion()` | `mobilityduckFullVersion()` |

The original `mobilitydb_*` names are also registered as aliases that
return MobilityDuck's version stamp, so the same query text works on
Expand Down Expand Up @@ -278,4 +278,4 @@ These MobilityDB type families aren't part of MobilityDuck today:

*Spotted something that should work but doesn't? Please open an
issue with the function signature you tried to call and the version
line from `mobilityduck_full_version()`.*
line from `mobilityduckFullVersion()`.*
8 changes: 4 additions & 4 deletions src/mobilityduck_extension.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -334,21 +334,21 @@ static void LoadInternal(ExtensionLoader &loader) {
}


// Register scalar function: mobilityduck_openssl_version
// Register scalar function: mobilityduckOpenSSLVersion
auto mobilityduck_openssl_version_scalar_function =
ScalarFunction(
"mobilityduck_openssl_version",
"mobilityduckOpenSSLVersion",
{LogicalType::VARCHAR},
LogicalType::VARCHAR,
MobilityduckOpenSSLVersionScalarFun
);
duckdb::RegisterSerializedScalarFunction(loader, mobilityduck_openssl_version_scalar_function);

duckdb::RegisterSerializedScalarFunction(loader, ScalarFunction(
"mobilityduck_version", {}, LogicalType::VARCHAR,
"mobilityduckVersion", {}, LogicalType::VARCHAR,
MobilityduckVersionScalarFun));
duckdb::RegisterSerializedScalarFunction(loader, ScalarFunction(
"mobilityduck_full_version", {}, LogicalType::VARCHAR,
"mobilityduckFullVersion", {}, LogicalType::VARCHAR,
MobilityduckFullVersionScalarFun));
// Portable-SQL aliases — MobilityDB publishes `mobilitydbVersion` and
// `mobilitydbFullVersion`, so a query that probes for the engine version
Expand Down
16 changes: 13 additions & 3 deletions test/sql/parity/022_temporal.test
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,21 @@ require mobilityduck
# Utility functions
# =============================================================================

# MobilityDuck exposes `mobilityduck_version()` /
# `mobilityduck_full_version()` instead of the MobilityDB names — the
# MobilityDuck exposes `mobilityduckVersion()` /
# `mobilityduckFullVersion()` instead of the MobilityDB names — the
# brand divergence is intentional. PR #28.
query I
SELECT mobilityduck_version() LIKE 'MobilityDuck%';
SELECT mobilityduckVersion() LIKE 'MobilityDuck%';
----
true

query I
SELECT mobilityduckFullVersion() LIKE mobilityduckVersion() || ', linked MEOS %';
----
true

query I
SELECT mobilityduckOpenSSLVersion('x') LIKE 'Mobilityduck x, my linked OpenSSL version is %';
----
true

Expand Down
Loading