Repository navigation
Name the MobilityDuck version functions in camelCase - #495
Merged
estebanzimanyi merged 1 commit intoOct 24, 2026
Merged
estebanzimanyi merged 1 commit into
estebanzimanyi merged 1 commit into
Conversation
mobilityduckVersion, mobilityduckFullVersion and mobilityduckOpenSSLVersion are the SQL names of MobilityDuck's version functions, after MobilityDB's mobilitydbVersion and mobilitydbFullVersion; OpenSSL keeps its spelling, as the function's C executor MobilityduckOpenSSLVersionScalarFun spells it and as clusterDBSCAN and asMVTGeom keep their acronyms. The C entry point mobilityduck_version, which the DuckDB loader looks up by the extension's name, keeps its name. The parity documents name the new SQL names, and their table pairs them with MobilityDB's mobilitydbVersion and mobilitydbFullVersion. Witness: on main 3da720b the three are registered as mobilityduck_version, mobilityduck_full_version and mobilityduck_openssl_version, the only SQL names of the extension spelled with an underscore beside the camelCase surface MobilityDB declares. Measured: the native build of the branch runs the whole suite green, 4886 assertions in 121 test cases; 022_temporal reads mobilityduckVersion, mobilityduckFullVersion, which starts with it and names the linked MEOS, and mobilityduckOpenSSLVersion('x'). Why: a SQL name of the MobilityDB ecosystem is camelCase, with no underscore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mobilityduckVersion, mobilityduckFullVersion and
mobilityduckOpenSSLVersion are the SQL names of MobilityDuck's version
functions, after MobilityDB's mobilitydbVersion and
mobilitydbFullVersion; OpenSSL keeps its spelling, as the function's C
executor MobilityduckOpenSSLVersionScalarFun spells it and as
clusterDBSCAN and asMVTGeom keep their acronyms. The C entry point
mobilityduck_version, which the DuckDB loader looks up by the
extension's name, keeps its name. The parity documents name the new
SQL names, and their table pairs them with MobilityDB's
mobilitydbVersion and mobilitydbFullVersion.
Witness: on main 3da720b the three are registered as
mobilityduck_version, mobilityduck_full_version and
mobilityduck_openssl_version, the only SQL names of the extension
spelled with an underscore beside the camelCase surface MobilityDB
declares.
Measured: the native build of the branch runs the whole suite green,
4886 assertions in 121 test cases; 022_temporal reads
mobilityduckVersion, mobilityduckFullVersion, which starts with it and
names the linked MEOS, and mobilityduckOpenSSLVersion('x').
Why: a SQL name of the MobilityDB ecosystem is camelCase, with no
underscore.