Skip to content

Add deterministic browser coverage for documentation routes - #62

Merged
Microck merged 8 commits into
mainfrom
qa/documentation-browser-flows
Oct 19, 2026
Merged

Microck merged 8 commits into
mainfrom
qa/documentation-browser-flows

Conversation

@Microck

@Microck Microck commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Changes

  • Add pinned tester-army/e2e coverage for all 43 documentation routes against the production server.
  • Patch quinn-proto to 0.11.18, rustls to 0.23.46 and zip to 9.0.0; the latter retains Rust 1.88 support. Preserve the updater's explicit archive/path/type validation.
  • Update vulnerable npm transitive packages and Vitest to 5.0.5. npm audit now reports zero advisories locally.
  • Confine the MCP CLI fixture's CODEX_HOME to its temporary test directory; inherited host settings previously changed the expected dry-run plan.

Verification

  • Initial docs browser CI: 43/43 passed.
  • Updated local full Rust suite: 976 passed, zero failed, three ignored on Rust 1.99.1.
  • Actual TUI acceptance with the new Vitest: 13/13 passed. MCP applicability checks: 3/3 passed. Docs checks/build pass.
  • Cross-platform, Rust 1.88/MSRV, security and latest browser CI still required on 1916040. Local rustfmt unavailable in the selected toolchain; CI formatting remains required.

No provider credits, model calls, update-network operations or publication. PR open for review; both review bots requested.

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pangram-cli Ready Ready Preview Oct 19, 2026 8:57pm UTC

Microck commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@codex review

Please review the current PR changes for correctness, regressions, security, and whether the tests actually cover the claimed behavior. I will address actionable findings and rerun verification.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T20:59:24.964351Z 15d4b06 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1872170e-4f42-4808-8b68-51e8179ab8c5
📥 Commits

Reviewing files that changed from the base of the PR and between 43fd022 and 15d4b06.

⛔ Files ignored due to path filters: 2
  • Cargo.lock is excluded by !**/*.lock
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing: 13
  • .github/workflows/browser.yml
  • .gitignore
  • .tegami/audited-dependencies.md
  • Cargo.toml
  • README.md
  • docs-app/e2e-runner.mjs
  • docs-app/e2e.config.ts
  • docs-app/package.json
  • docs-app/tests/docs.e2e.ts
  • docs-app/tsconfig.e2e.json
  • docs-app/tsconfig.json
  • package.json
  • tests/mcp-cli-contract.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

This PR adds production-build browser coverage for documentation routes and updates dependencies and test isolation.

  • Browser CI checks documentation page titles against discovered routes; the test suite requires Node.js 24.8 or newer.
  • Dependency updates include zip 9.0.0 and npm packages; the MCP contract test confines CODEX_HOME to its temporary test home.
  • The author reports passing local Rust, TUI, MCP, docs-build, isolated E2E typecheck, and earlier 43-route browser checks. Cross-platform and Rust 1.88/MSRV validation, security review, formatting, and latest browser CI results are not established for the current commit.

Walkthrough

The docs app adds browser end-to-end tests that discover documentation pages and check their exact-title headings in Chromium. A Node.js runner and E2E configuration support the tests. A GitHub Actions workflow builds the docs, runs the tests, and uploads results after failures. The changes also update dependency records, raise the minimum Node.js version, and set CODEX_HOME for an isolated MCP CLI test.

Sequence Diagram(s)

sequenceDiagram
  participant GitHubActions as GitHub Actions
  participant Runner as e2e-runner.mjs
  participant E2ECLI as e2e CLI
  participant NextServer as Next.js server
  participant Chromium
  GitHubActions->>Runner: Run browser tests
  Runner->>E2ECLI: Invoke CLI with forwarded arguments
  E2ECLI->>NextServer: Start configured app server
  E2ECLI->>Chromium: Run documentation route tests
  Chromium->>NextServer: Request documentation route
  NextServer-->>Chromium: Render documentation page
Loading

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 15d4b

No confirmed issue prevents merging. Confirm the required Rust 1.88 CI check before completing the merge.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Microck commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15f5e22a10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/browser.yml
Comment thread .github/workflows/browser.yml Outdated
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Head commit changed.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Rate Limit Exceeded

@Microck have exceeded the limit for the number of chat messages per hour. Please wait 23 minutes and 40 seconds before sending another message.

Microck commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@codex review

Please re-review the current head after the fixes. Earlier findings have been addressed with targeted verification; check for remaining issues rather than relying on previous-head results.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 53 minutes.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 125472322f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Microck commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@codex review

Current-head follow-up after the latest reviewed edge cases and test/workflow corrections. Please check the updated implementation and assertions for remaining actionable issues.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Rate Limit Exceeded

@Microck have exceeded the limit for the number of chat messages per hour. Please wait 17 minutes and 46 seconds before sending another message.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: d1da9b90f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Microck commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

Retrying after the 53-minute included-review cooldown reported at 18:56 UTC has elapsed. Current branch includes the reviewed dependency fixes, portable launcher, action pins and explicit trace retention; no billing/settings changes requested.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

Microck commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

Vercel preview exposed a production-build boundary issue: docs-app's tsconfig included browser test files whose packages are only root tooling dependencies. Production now excludes those files, while a separate tsconfig.e2e.json is explicitly typechecked in browser CI. Local isolated typecheck and docs production build pass.

@coderabbitai full review
@codex review

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 15d4b061f7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Microck commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

Retrying the current-head review after the quoted included-review cooldown. Please report any remaining actionable findings.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Pull request base or head changed.

@Microck
Microck merged commit 4d4a0ec into main Oct 19, 2026
29 checks passed

This branch was successfully deployed

1 active deployment
Preview — 15d4b061 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant