Repository navigation
Add deterministic browser coverage for documentation routes - #62
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@coderabbitai full review @codex review Please review the current PR changes for correctness, regressions, security, and whether the tests actually cover the claimed behavior. I will address actionable findings and rerun verification. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
This PR adds production-build browser coverage for documentation routes and updates dependencies and test isolation.
WalkthroughThe docs app adds browser end-to-end tests that discover documentation pages and check their exact-title headings in Chromium. A Node.js runner and E2E configuration support the tests. A GitHub Actions workflow builds the docs, runs the tests, and uploads results after failures. The changes also update dependency records, raise the minimum Node.js version, and set Sequence Diagram(s)sequenceDiagram
participant GitHubActions as GitHub Actions
participant Runner as e2e-runner.mjs
participant E2ECLI as e2e CLI
participant NextServer as Next.js server
participant Chromium
GitHubActions->>Runner: Run browser tests
Runner->>E2ECLI: Invoke CLI with forwarded arguments
E2ECLI->>NextServer: Start configured app server
E2ECLI->>Chromium: Run documentation route tests
Chromium->>NextServer: Request documentation route
NextServer-->>Chromium: Render documentation page
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
|
@coderabbitai full review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15f5e22a10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Rate Limit Exceeded
|
|
@coderabbitai full review @codex review Please re-review the current head after the fixes. Earlier findings have been addressed with targeted verification; check for remaining issues rather than relying on previous-head results. |
|
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@coderabbitai full review @codex review Current-head follow-up after the latest reviewed edge cases and test/workflow corrections. Please check the updated implementation and assertions for remaining actionable issues. |
Rate Limit Exceeded
|
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@coderabbitai full review Retrying after the 53-minute included-review cooldown reported at 18:56 UTC has elapsed. Current branch includes the reviewed dependency fixes, portable launcher, action pins and explicit trace retention; no billing/settings changes requested. |
✅ Action performedFull review finished. |
|
Vercel preview exposed a production-build boundary issue: docs-app's tsconfig included browser test files whose packages are only root tooling dependencies. Production now excludes those files, while a separate tsconfig.e2e.json is explicitly typechecked in browser CI. Local isolated typecheck and docs production build pass. @coderabbitai full review |
✅ Action performedFull review finished. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@coderabbitai full review Retrying the current-head review after the quoted included-review cooldown. Please report any remaining actionable findings. |
|
Changes
Verification
No provider credits, model calls, update-network operations or publication. PR open for review; both review bots requested.