Repository navigation
feat: add Pangram 4.1 short-text interpretation guidance - #63
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
This PR adds a caution to human-readable AI-detection results when validated segment metadata reports fewer than 150 words; it does not change scores or machine-readable output.
WalkthroughThe CLI now shows a short-text caution in Pretty, Markdown, and TUI AI results when the returned segments contain fewer than 150 words in total and the segment counters match. The caution does not change scores or machine-readable output. Documentation describes the limits of the Pangram 4.1 announcements and states that the CLI does not derive a dashboard percentage range from segment confidence. Sequence Diagram(s)sequenceDiagram
participant PrettyMarkdown as Pretty and Markdown output
participant Guidance as short_text_caution
participant TUI as TUI result rendering
PrettyMarkdown->>Guidance: Pass AI detection result
Guidance-->>PrettyMarkdown: Return caution or None
TUI->>Guidance: Pass AI detection result
Guidance-->>TUI: Return caution or None
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
|
@coderabbitai full review @codex review Please review the short-text threshold/aggregation, output compatibility, real PTY coverage and documented 4.1 API boundary. This is stacked on #62; implementation is limited to verified public announcement guidance, not undocumented wire fields. |
✅ Action performedFull review finished. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Vercel preview exposed a production-build boundary issue: docs-app's tsconfig included browser test files whose packages are only root tooling dependencies. Production now excludes those files, while a separate tsconfig.e2e.json is explicitly typechecked in browser CI. Local isolated typecheck and docs production build pass. @coderabbitai full review |
|
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@coderabbitai full review Retrying the current-head review after the quoted included-review cooldown. Please report any remaining actionable findings. |
|
|
The prerequisite #62 is now merged, with all 28 returned checks and Vercel preview passing and both current-head reviews clean. Retargeted this PR to main. Please review the remaining Pangram 4.1 guidance delta against main. @coderabbitai full review |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbd7dc69e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@coderabbitai full review Latest fix validates complete segment metadata before making a short-document claim; documented contract and regression tests updated. |
✅ Action performedFull review finished. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Scope and dependency
Stacked on #62 (
qa/documentation-browser-flows) to reuse its dependency/security and browser-test fixes. This PR is not a claim of complete 4.1 wire compatibility: public docs and SDK still show the 4.0 contract and do not document the new dashboard range fields. Server-side accuracy claims are not independently benchmarked here.Verification
Sources and precise limitations:
docs/pangram-4-1-investigation.md.