Skip to content

style(yasr): give the Response view a Lucide outline icon #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MathiasVDA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

style(yasr): give the Response view a Lucide outline icon #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/response-icon.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@matdata/yasr": patch
---

The Response view now has an outline icon that matches the Table, Geo, Graph, Chart and Explain views, instead of a filled Font Awesome glyph.
5 changes: 2 additions & 3 deletions packages/yasr/src/plugins/response/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { turtle } from "codemirror-lang-turtle";
import { javascript } from "@codemirror/legacy-modes/mode/javascript";
import { addClass, removeClass } from "@matdata/yasgui-utils";
import { DeepReadonly } from "ts-essentials";
import { icon } from "../../describe/icons";
import {
extractUriAtOffset,
buildSubjectOfQuery,
Expand Down Expand Up @@ -53,9 +54,7 @@ export default class Response implements Plugin<PluginConfig> {
return true;
}
public getIcon() {
const icon = document.createElement("i");
icon.className = "fas fa-align-left";
return icon;
return icon("file-code");
}
download(filename?: string) {
if (!this.yasr.results) return;
Expand Down
Loading