Repository navigation
style(yasr): give the Response view a Lucide outline icon - #238
Open
MathiasVDA wants to merge 1 commit into
Open
MathiasVDA wants to merge 1 commit into
MathiasVDA wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mathias · project thread
Before: the Response tab in the results header used the filled Font Awesome
fa-align-leftglyph, which looked heavier than and out of place next to the Table, Geo, Graph, Chart and Explain icons.After: the Response tab uses the Lucide
file-codeicon (a document with<>), drawn the same way as the other views: 24×24 viewBox, outline only, 1.75 stroke,currentColor.How
All view plugins already use inline Lucide outline icons; Response was the only one still on Font Awesome.
getIcon()now returnsicon("file-code")from yasr's existingdescribe/icons.tsset, so nothing new is added to the bundle.file-codewas picked overbracesandcode-xmlbecause it matches the visual weight of the table and map icons and does not suggest JSON only (the view also shows XML and Turtle). Changeset included (@matdata/yasrpatch).Before/after screenshots (light and dark) are in the project thread.
Generated by Claude Code