fix(lancedb): translate the spill failure on the write path too - #465
Merged
Merged
Conversation
#463 translated 'Execution error: Spill has sent an error' only inside the read deadline wrapper, on the assumption the failure came from a query. The integration-branch soak that ran with #463 says otherwise: 42 spill failures, 0 translated, 104 unrecoverable rows, and the traceback frames put it in upsert -> merge_insert -> execute_merge_insert, i.e. under _locked. Apply the same translation there; the write is idempotent by id, so the worker's retry is the right answer. Test: the phrase raised inside _locked becomes VectorStoreBusyError; fails against main's _locked. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
gloryfromca
enabled auto-merge (squash)
September 24, 2026 09:34
This was referenced Sep 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#463 translated
LanceError(IO): Execution error: Spill has sent an errorinto the retryableVectorStoreBusyErroronly inside the read deadline wrapper. The soak that ran with #463 shows that was the wrong place: 42 spill failures, 0 translated, 104 rows filed unrecoverable. The traceback frames (Windows soak,everos_soak_run3_integration883007c/server.log):So it is
merge_insertunder_locked. Same translation there; the write is idempotent by id, so the worker's retry (backoff,ExternalServiceErrorpath) is the right answer. Marker docstring corrected (four runs: 187 / 180 / 34 / 42).Area
Verification
_lockedbecomesVectorStoreBusyError; against main's_lockedit fails (bareRuntimeErrorpropagates).test_core/test_persistence/test_lancedb+test_cascadegreen.lancedb_transient_execution_errormust be > 0 andcascade_worker_unrecoverableback to the fuzz baseline (ValidationErrorcount).🤖 Generated with Claude Code