Skip to content

Omit onboarding credentials from pytest failure reports #8203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 3 commits into from
Oct 28, 2026
Merged

Omit onboarding credentials from pytest failure reports #8203

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70c3d48
Hide onboarding API keys in pytest failure locals
dmalysza Oct 28, 2026
ad3613b
Omit credential-bearing helpers from pytest failure reports
dmalysza Oct 28, 2026
a9a9a4b
Remove new onboarding unit tests
dmalysza Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions utils/onboarding/backend_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ def _headers():
"""The backend can raise a 429 error if the rate limit is reached.
We can use several app keys trying to avoid the rate limit.
"""
# Omit credential-selection locals from pytest failure reports.
__tracebackhide__ = True

# Retrieve the mandatory API and APP keys.
api_key = os.getenv("DD_API_KEY_ONBOARDING")
app_key = os.getenv("DD_APP_KEY_ONBOARDING")
Expand Down Expand Up @@ -114,6 +117,9 @@ def _make_request(

With the defaults, this will retry for approximately 5 minutes.
"""
# Omit authentication headers from pytest failure reports.
__tracebackhide__ = True

start_time = time.perf_counter()
for _attempt in range(max_retries):
try:
Expand Down Expand Up @@ -172,6 +178,9 @@ def _validate_profiler_response(json: dict):


def _query_for_profile(runtime_id: str):
# This caller also retains authentication headers while the request runs.
__tracebackhide__ = True

url = f"{API_HOST}/api/unstable/profiles/list"
headers = _headers()
headers["Content-Type"] = "application/json"
Expand Down
Loading