Repository navigation
Conversation
Preserve credential string values for HTTP authentication while redacting their repr in request and key-selection locals. Assisted by Codex (GPT-6).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
|
Use native traceback filtering to omit authentication locals while retaining the public caller and operation error. Restore ordinary credential strings and HTTP preparation. Assisted by Codex (GPT-6).
dmalysza
changed the title
Contributor
🎉 All green!🧪 All tests passed 🔗 Commit SHA: a9a9a4b | Docs | View more details | Give us feedback! |
Keep the native pytest traceback omission scoped to the existing credential-retaining helpers and validate with existing repository checks. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
gh-worker-ownership-write-b05516
Bot
removed the request for review
from a team
October 28, 2026 03:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboarding backend failures expose
DD-API-KEYandDD-APPLICATION-KEYthrough pytest failure locals. SDS-flagged CI logs identify the shared onboarding header producer, also used by auto_inject and dd-trace-py.Use pytest's native
__tracebackhide__in the three helpers that retain credential-selection values or authentication headers:_headers,_make_requestand_query_for_profile. Pytest omits those internal frames and their locals entirely. Public caller frames and the existing method, URL and timeout error remain visible. Credential values, request preparation, key-pair selection, retries, backoff, validation and ordinary logs are unchanged. This addresses the onboarding header producer; other credential detections require separate attribution.Key files to review
Validation
./run.sh TEST_THE_TEST tests/test_the_test/test_junit.py tests/test_the_test/test_itself.pypassed all 3 selected tests, covering JUnit failure reporting and scenario coherence. No unit tests or assertions are added by this PR../format.sh --check: all checks passed, including mypy, import policy, formatting, YAML, manifest checks, shellcheck and Node linters.git diff --check: passed. The final diff contains only 9 lines in the three existing credential-retaining helpers.Assisted by Codex (GPT-6).