Skip to content

fix(ci): pair the development Java agent with its OpenFeature provider - #8188

Merged
cbeauchesne merged 1 commit into
mainfrom
vickie/java-dev-matching-openfeature
Oct 27, 2026
Merged

cbeauchesne merged 1 commit into
mainfrom
vickie/java-dev-matching-openfeature

Conversation

@vjfridge

@vjfridge vjfridge commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Our Java Feature Flags documentation advises customers: “Use the same version of dd-java-agent and dd-openfeature.” Java development CI currently does something different: it downloads the development Java agent but builds the test application with the latest released OpenFeature provider from Maven Central.

dd-trace-java #12976 is a concrete example of why that mismatch matters. Following the Java Feature Flags API refactor, the development agent makes older providers return caller defaults instead of evaluating flags. Previously passing system tests now fail when CI combines agent 1.69.0-SNAPSHOT with provider 1.68.0. On unchanged system-tests main, test_default_agentless_source passes with the released 1.68.0 pair and fails when only the agent is upgraded to that development build.

These failures exercise a version pairing we advise customers not to use. This PR makes Java system-tests development CI download the provider alongside the agent from the same development branch, so it tests the matching components together.

Changes

Download dd-openfeature.jar alongside dd-java-agent.jar from the selected Java development branch. The existing weblog and parametric installers already consume the custom provider JAR. A missing provider download fails the loader instead of silently falling back to a released version. Java Lambda retains its existing agent-only download.

This fixes shared development-artifact selection independently of #8093; no test assertions or activation gates change.

Validation

Ran Test_FFE_Agentless_Configuration::test_default_agentless_source using unmodified main test/application sources (f95c57973), then the downloader change:

Agent Provider Result
Released 1.68.0 Released 1.68.0 Passed
Development 1.69.0-SNAPSHOT (df2ab9bf59) Released 1.68.0 Failed: default instead of on-value; no configuration requests
Development 1.69.0-SNAPSHOT (df2ab9bf59) Development 1.69.0-SNAPSHOT Passed; configuration fetched successfully
  • Verified the development provider manifest inside the rebuilt Spring Boot application.
  • Checked default/custom branch selection, failure on a missing provider, and unchanged Java Lambda selection.
  • ./format.sh --check passed.

Live validation covered the focused agentless test on ARM64; the full Java matrix remains for CI.

Use the provider artifact from the selected Java development branch so FFE tests do not mix a development agent with a released provider.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-6 <noreply@localhost>
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/scripts/load-binary.sh                                            @DataDog/system-tests-core

@vjfridge
vjfridge marked this pull request as ready for review October 26, 2026 22:19
@vjfridge
vjfridge requested a review from a team as a code owner October 26, 2026 22:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T22:20:57.548268Z 8e24327 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Pipelines  Tests

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

DataDog/system-tests | Ubuntu_24_10_amd64.CON: [test-app-ruby-container]

View more details · View in GitLab

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8e24327 | Docs | View more details | Give us feedback!

@cbeauchesne
cbeauchesne merged commit 8c184c8 into main Oct 27, 2026
2200 of 2202 checks passed
@cbeauchesne
cbeauchesne deleted the vickie/java-dev-matching-openfeature branch October 27, 2026 13:53
vjfridge added a commit that referenced this pull request Oct 27, 2026
Include the matching Java development provider download from #8188 and current main updates.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-6 <noreply@localhost>
vjfridge added a commit that referenced this pull request Oct 27, 2026
Include the matching Java development provider download from #8188 and current main updates.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-6 <noreply@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants