Repository navigation
Added support for reading patchliner e data (different chip layout) - #43
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 97.67% 97.71% +0.04%
==========================================
Files 3 3
Lines 258 263 +5
==========================================
+ Hits 252 257 +5
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kwabenantim
requested changes
Oct 7, 2026
kwabenantim
left a comment
kwabenantim
left a comment
Member
There was a problem hiding this comment.
It looks like the list of well labels was transposed compared to the data. The Syncropatch data has "Chiplayout":{"WP_nCols":24,"WP_nRows":16} which became a 24 x 16 list-of-lists containing the labels.
Co-authored-by: Kwabena Amponsah <kwabenantim@yahoo.com>
Member
Author
|
Thanks @kwabenantim ! I added a note that the internal matrix is confusing and added tests for this too. Great catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New patchliner uses the same data format, so all the hard bits should be the same. This PR replaces the hardcoded chip layout with one read from the json meta data.