[CaffeinatedCoder]

Closes #152
Closes #157
Closes #159
Closes #160
Closes #161
Closes #162

Problem

An assertion of CodoMetis.TypeKit.Testing on a Task fails a test only through the task it returns. CMTK0003 reported one dropped as a statement, but not one passed through a plain Task's ConfigureAwait or WaitAsync, or sitting in a ?:, ?? or switch (#152). Nor did it report one handed to Task.WhenAll, Task.WhenAny and their kin (#157). In each of these, a failing assertion leaves its task unobserved and the test passes.

The sweep of the same input class found four forms on the Result side that 2.2.0 code can contain:

• a dropped Task.WhenAny of Result tasks (CMTK0003 misses a Task.WhenAny of Result tasks dropped without await #159);
• Wait() on a branch (CMTK0003 misses Wait() on a ?:, ?? or switch of Result tasks #160);
• an array written in Task.WaitAll or Task.WaitAny (CMTK0003 misses an array of Result tasks written in Task.WaitAll or Task.WaitAny #161);
• a dropped Task.WhenEach (CMTK0003 misses a dropped Task.WhenEach of Result tasks #162).

The maintainer took them into 2.3.0 (decision 0119).

Change

• IgnoredOutcomeAnalyzer, one shared path for both forms of the rule, no special case beside it:
  • Tasks.PassesOn takes a plain Task's ConfigureAwait and WaitAsync.
  • The pending-assertion check runs in the Producers loop that already judged each branch.
  • DroppedAssertion reports an assertion handed to Task.WhenAll, Task.Run or Task.WhenEach whose task is dropped, and to Task.WhenAny in any use. MadeAssertions/HandsOn follow arrays, collection expressions, Select, query syntax, ToList, method groups, and an async lambda that awaits one with no catch between.
  • The conversion to a plain Task and Wait use the same check. Task.WaitAny reports each assertion it was given. A loop that never reads the assertions its header made is reported. Task.WaitAll throws the failures, so it stays silent.
  • Tasks.PendingOutcome sees a task of a task (CMTK0003 misses a Task.WhenAny of Result tasks dropped without await #159).
  • AnalyzeWait goes through Producers (CMTK0003 misses Wait() on a ?:, ?? or switch of Result tasks #160).
  • An array of tasks converted whole reports each element's call (CMTK0003 misses an array of Result tasks written in Task.WaitAll or Task.WaitAny #161).
  • A dropped WhenEach of tasks the statement made is a sequence of results (CMTK0003 misses a dropped Task.WhenEach of Result tasks #162).
  • ReturnsItsStoredReceiver takes a WhenAny of held tasks, which returns one of them, so that form is now silent where 2.2.0 reported it awaited.
• Variants/DroppedTaskShapes (new catalogue) and DroppedTaskVariantTests:
  • 25 calls: every assertion on a Task and a ValueTask, plus a call returning a task of a Result.
  • 9 pass-throughs, 39 forms (including the silent controls) and 11 uses.
  • 830 cases, one compilation per call and form. A single compilation per call overflowed the verifier's recursive matching.
• New test A_WhenAny_of_results_the_statement_made_reports_and_of_held_ones_is_silent.
• Decision 0119 (design/adr/0119-…): before the tag, a gap an Error has ships in that release. The rule stops at the tag, after which decision 34 holds. 0118's index row says it is widened by 0119.
• Docs:
  • The Analyzers README's assertion paragraph, "Waiting and loops", and the "What a new version may change" exception list.
  • The CMTK0003 row of design/analyzers.md.
  • The changelog: the Testing line, and a Changed line that says a 2.2.0 build can fail on upgrade, which forms do it, and what to write instead.
  • Claims T02-a-few-2-2-forms-are-reported, T02-a-wrapped-assertion-is-reported, T02-combined-assertions-are-reported, T02-wait-all-observes-assertions and T02-when-any-of-results-is-reported.

Tests

• CodoMetis.TypeKit.Analyzers.Tests: 2679 passed. CodoMetis.TypeKit.Conventions.Tests: 2000 passed, with Samples and Probes built. CodoMetis.TypeKit.Oracles.Tests: 51 passed. docs-query check: clean.
• Each guard seeded and caught. The CMTK0003 misses dropped async assertions through Task wrappers and branches #152 fix three ways: without the plain Task in PassesOn, with the check limited to the statement's own call, and without the await condition. Then 18 seeds of the combinator and Result fixes, each failing the sweep (1 to 378 cases) and, for CMTK0003 misses a Task.WhenAny of Result tasks dropped without await #159, the new test.
• Input class: AIS, a call's task dropped or lost by a statement; the catalogue is new and holds every axis above. The weaving-review §8 neighbours (?? beside ?:, pass-throughs on a held task, held beside made) are axes of it.

🤖 Generated with Claude Code