Repository navigation
CMTK0003 misses unawaited assertions dropped together through Task.WhenAll #157
Description
Found while fixing #152 (its variant sweep covers one dropped call per statement, not a collection of them).
Problem
A statement that drops a Task.WhenAll of assertions of CodoMetis.TypeKit.Testing, unawaited, compiles with no CMTK0003, so a failing assertion's task goes unobserved and the test passes:
public static void Run(Task<Option<int>> option, Task<Result<Fault>> command)
{
Task.WhenAll(option.ShouldBeNone(), command.ShouldBeSuccess()); // no diagnostic
}Measured on fix/cmtk0003-wrapped-assertions (#152's fix) with the real analyzer and Testing assemblies, by an analyzer test expecting no diagnostic, which passed.
The rule's other form already reports the same shape: Task.WhenAll(orders.CancelAsync(a), orders.CancelAsync(b)); dropped is a "collection of Results" (CMTK0003), because WhenAll returns Task<Result[]>. Over assertions that return a plain Task, WhenAll returns a plain Task, which carries nothing the rule reads.
Expected
A dropped Task.WhenAll (and WhenAny?) whose arguments the statement made as pending assertions is reported, as a collection of results is; awaited, held or _ = stays silent. Add the shape to Variants/DroppedTaskShapes.
Release
Under decision 118 this reach can ship in 2.3.0 only before the tag; after it, it waits for 3.0.0. Decide whether 2.3.0 takes it.
Activity
fix: CMTK0003 reports assertions and results lost through Task's comb…
CaffeinatedCoder commentedon Oct 29, 2026
Fixed in #164 (into
release/2.3.0). CMTK0003 reports an assertion handed toTask.WhenAll,Task.RunorTask.WhenEachwhose task is dropped, and one given toTask.WhenAnyin any use, sinceWhenAnyfinishes with the first task and never faults. It counts arguments, arrays, collection expressions,Select, query syntax,ToList, method groups (pending.Select(OptionAssertions.ShouldBeNone)) and anasynclambda that awaits one with nocatchbetween.Task.WaitAnyis covered too: it returns an index and leaves every failure unobserved, so each assertion it was given is reported, with the assertion named.Task.WaitAllthrows anAggregateExceptionwhen one fails, so it observes them and stays silent. AWhenAnyof assertions converted to a plainTaskor waited for, and a loop that never reads the assertions its header made, are reported. Held tasks, an assertion discarded where it is made and one given to a call that returns no task stay silent. All of it is held byDroppedTaskVariantTests(830 cases).CaffeinatedCoder commentedon Oct 29, 2026
Fixed in #164, merged into
release/2.3.0(9878a6c).