Repository navigation
fix: PR hygiene runs every event's check to the end, with no concurrency group - #149
Merged
Merged
Conversation
…ncy group The group cancelled the runs of a pull request that was pushed and then labelled, given its milestone and its body within seconds; a run cancelled while its job went leaves a cancelled check run, and a cancelled run of the required "Labels and issue link" check left the pull request BLOCKED beside a later success. Measured on two draft pull requests with five events each: a group with cancel-in-progress: false still cancelled three of four runs, since a newer pending run replaces the older pending one; without a group all five ran. Earlier runs had failed on a payload without labels and the pull request was CLEAN once CI passed, also when the first run was held back to finish after the one that succeeded: the newest run decides the required check, not the last to finish. The header comment records both. Closes #144. Defect-Class: TOOL Found-By: US Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
CaffeinatedCoder
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
Problem
pr-hygiene.ymlhad a concurrency group withcancel-in-progress: true. A pull request pushed and then given its labels, milestone and body within seconds started four or five runs and the in-progress ones were cancelled. A cancelled run of the required "Labels and issue link" check left the pull request BLOCKED (#141, #142, #139) until it was re-run by hand, one at a time.Change
Drops the concurrency group in
.github/workflows/pr-hygiene.yml, so every event's run completes. The check takes seconds and reads only its payload, so a cancelled run saved nothing. The header comment records what was measured, on two draft pull requests with five events each:cancel-in-progress: falsestill cancels: a newer pending run replaces the older pending one. Three of four runs were cancelled (they started no job, so left no check run and blocked nothing, but the runs are missing).Tests
This pull request is its own test: opened without labels, then labels, milestone and body set within seconds. The result is recorded in a comment on #144. The scratch pull requests of the measurement are closed and their branches deleted. There is no code under test; the guard is the workflow itself, and the alternative (the group kept) is the measured revert.