Skip to content

Support RouterOS 7.x (WifiWave2 wireless + mtxrGaugeTable health) alongside 6.x, and add a Health tab - #135

Merged
TheWitness merged 11 commits into
developfrom
feat/wifiwave2-api-wireless
Nov 12, 2026
Merged

TheWitness merged 11 commits into
developfrom
feat/wifiwave2-api-wireless

Conversation

@TheWitness

@TheWitness TheWitness commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Summary

Brings the MikroTik plugin up to date with RouterOS 7.x while continuing to support RouterOS 6.x, and adds a Health tab. RouterOS 7 changed how several subsystems expose data over SNMP, which silently broke parts of the plugin on v7 devices; every change here is version-gated so pre-7.x devices behave exactly as before.

The plugin reads each device's RouterOS version (licVersion) and, for major version ≥ 7, uses the newer data paths below; versions < 7 keep using the existing SNMP collection (with the v7 paths falling back to SNMP whenever the API/command is unavailable, so a v7 device still on the legacy packages keeps working too).

RouterOS 7 updates

Wireless Aps / Wireless Registrations (WifiWave2)

The wireless views read the legacy mtxrWlApTable / mtxrWlRtabTable SNMP tables (.1.3.6.1.4.1.14988.1.1.1.2/.1.3), which RouterOS 7's WifiWave2 (/interface/wifi) driver no longer populates. For v7+, the poller now collects AP and client-registration data through the RouterOS API (/interface/wifi/print and /interface/wifi/registration-table/print), falling back to SNMP when the API/command is unavailable.

  • Command errors (!trap/!fatal, e.g. a v7 device without the WifiWave2 package) are detected via a shared mikrotik_api_query() helper and trigger the SNMP fallback before any database write.
  • AP index derives from the stable, unique RouterOS .id so distinct interfaces never collide on the (host_id, index, apSSID) key.

System Health (mtxrGaugeTable)

RouterOS 7 reports health sensors through the dynamic mtxrGaugeTable (mtxrHealth.100, keyed by sensor name) rather than the fixed mtxrHealth.1..18 scalars, which are mostly empty on v7. For v7+, the poller collects the gauge table (falling back to the fixed scalars if empty; pre-7.x keeps the scalars), storing every sensor in a new plugin_mikrotik_health_sensors table (so multi-sensor hardware — multiple temps, fans, PSUs — is represented) and overlaying the well-known single-instance sensors onto the legacy plugin_mikrotik_system_health columns so the existing per-metric health graphs keep working. mtxrGaugeUnit deci-units (dV/dA/dW) are scaled by 10. Schema version to 3.4.

New Health tab

Adds a Health tab to mikrotik.php listing the collected sensors per device (device, sensor, value, unit, last seen), with filtering/sorting and a navigation entry.

Graph data path brought into the repo

The script-server data backends and data-query definitions that feed the graph templates — previously only deployed under cacti/scripts and cacti/resource — are now version-controlled in the plugin so the data-query to script to schema contract can be audited in one place:

  • scripts/ss_mikrotik_*.php — the script-server backends. ss_mikrotik_health.php is fixed to read the real schema (maps each graph metric to the v7 gauge sensor, then the legacy Hl* column) so health graphs gather data on v7 and 6.x. ss_mikrotik_wireless_reg.php is aligned to the mikrotik_wireless_reg.xml contract (real TxBytes/Strength/... columns instead of non-existent ap* names).
  • resource/script_server/mikrotik_*.xml — the data query definitions.
  • .github/copilot-instructions.md documents that regenerating the templates/ *.xml.gz packages is the last step, once schema/poller/UI/scripts/resource changes are complete.

Testing

  • Pest unit tests for all new pure helpers (version gate, counter/rate parsing, uptime formatting, gauge unit/scale/column mapping, wifi index); uninstall DROP-count updated. Full suite: 121 passing; changed-line coverage 100%; i18n template and manifest checks pass; php -l clean across all files.
  • Validated end-to-end against a live hAP ax3 running RouterOS 7.25.1: wireless collectors return 8 registrations + 2 APs; the gauge collector stores cpu-temperature=59 and overlays HlCpuTemperature; ss_mikrotik_health.php returns 59 for the processorTemperature metric.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 11, 2026 19:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Collectors can treat RouterOS command errors as valid data, replacing AP snapshots or marking registrations absent while suppressing SNMP fallback, and interface-index collisions can overwrite distinct AP records.

2 open issues
What changed in this PR

This PR updates the Cacti MikroTik poller to collect wireless AP and registration data through the RouterOS API on version 7+, restoring visibility for devices using the newer Wi-Fi driver.

Changes:

  • Adds version-based collection routing, retaining SNMP for older devices and as a fallback when API connection setup fails.
  • Adds API collectors and helpers for counters, rates, and uptime.
  • Adds parsing-helper tests and documents the change.
File Description
tests/​Unit/​PollerParsingTest.php Tests version detection, counter parsing, rate clamping, and uptime formatting.
poller_mikrotik.php Adds version-aware routing and wireless API collection.
CHANGELOG.md Documents RouterOS 7+ wireless collection support.

Review effort: Balanced

Comment thread poller_mikrotik.php Resolved
Comment thread poller_mikrotik.php Resolved

@somethingwithproof somethingwithproof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Blocker: Command errors are treated as data. parseResponse() puts !trap/!fatal replies under $PARSED['!trap'][] (RouterOS/routeros_api.class.php:197). On a v7 device still running the legacy wireless package, or one with no wifi at all, /interface/wifi/print traps. collect_wireless_aps_api() then iterates that '!trap' entry as a row, inserts a junk AP (name falls back to wifi1, empty SSID/BSSID), deletes the real rows and returns true, so the SNMP fallback never runs. The registration collector does the same and marks every registration absent. That is the opposite of the fallback the description promises. Check each response for !trap/!fatal before touching the tables, disconnect, and return false.
  • Blocker: CI is red. Patch coverage reports 0/27 changed lines covered, including the checkHost() version dispatch at poller_mikrotik.php:1106-1121 and the new helpers starting at 2410, even though the helpers have Pest cases, so those cases aren't counted against the source lines as loaded. The dispatch (API success, API false falling back to SNMP, pre-v7 skipping API) also needs a test, since it is the behavioral core of this change.
  • Suggestion: The AP index comes from the trailing digits of the interface name, with an ordinal fallback. RouterOS interface names are user-editable, so wifi2 and guest2, or an ordinal that equals another interface's suffix, can collide on (host_id, index, apSSID) when they share an SSID. One AP then overwrites the other's BSSID and client counts. Derive the index from the interface's .id (*1A hex to int) instead, which RouterOS guarantees unique per device.
  • Suggestion: checkHost() runs the licVersion query on every cycle even when neither wireless collector is due. Move it inside the runCollector() checks.

RouterOS 7 reports health via the dynamic mtxrGaugeTable (mtxrHealth.100)
keyed by sensor name, leaving the fixed mtxrHealth.1..18 scalars mostly
empty. For 7.x+ devices, collect the gauge table into a new
plugin_mikrotik_health_sensors table (the full multi-sensor set) and
overlay well-known single-instance sensors onto the legacy
plugin_mikrotik_system_health columns so existing graphs keep working;
pre-7.x devices keep using the fixed scalars. Schema version 3.4.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@TheWitness TheWitness changed the title Collect wireless AP/registration data via RouterOS API on RouterOS 7+ Restore Nov 11, 2026

@somethingwithproof somethingwithproof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two blockers from the last round are still open. c5a17a0 doesn't touch collect_wireless_aps_api()/collect_wireless_reg_api():

  • Blocker: !trap/!fatal replies from /interface/wifi/print and /interface/wifi/registration-table/print are still iterated as rows (parseResponse() files them under $PARSED['!trap']). On a v7 device running the legacy wireless package, or one without wifi, the AP collector writes a junk row, deletes the real ones and returns true, so the SNMP fallback never runs. The registration collector marks every row absent. Check for an error response before touching the tables, then disconnect and return false.
  • Blocker: CI is still red. Patch coverage is now 2/67 lines. The checkHost() wireless dispatch and the new collect_system() gauge dispatch (mikrotik_version_is_seven_plus(...) && collect_health_gauge($host)) both need a test for each branch.

On the new health-sensor commit:

  • Suggestion: This is a second, independent feature (v7 health via mtxrGaugeTable, a new table, and a 3.4 schema bump) inside a PR about wireless collection. The PR title is now "Restore". Please split it into its own PR so each can be reviewed and reverted on its own, and restore a descriptive title here.
  • Suggestion: plugin_mikrotik_health_sensors is write-only. Nothing in the plugin reads it (no view, data query or graph template), so the multi-sensor data the changelog describes isn't visible anywhere. Either add the consumer in the same PR or defer the table until there is one.
  • Suggestion: The overlay only writes legacy columns for sensors that are present. If a mapped sensor disappears (PSU removed, firmware renames fan1 to fan1-speed), its plugin_mikrotik_system_health column keeps the last value indefinitely, and graphs flatline at a stale reading instead of going unknown. Null the mapped columns that weren't seen this cycle.
  • Nit: voltage/psu1-voltage, current/psu1-current and power/power-consumption each map to one column with first-walked-wins. That's fine, but a comment saying the walk order decides would save the next reader from wondering.

The early return true sits at the end of collect_system(), so it doesn't skip any other collection, and the unit scaling (dV/dA/dW to /10) matches what the legacy compensation heuristics were approximating.

Adds a Health tab to mikrotik.php that lists the RouterOS 7 health sensors collected into plugin_mikrotik_health_sensors (device, sensor, value, unit, last seen), with a matching navigation entry.

Brings the ss_mikrotik_*.php script-server data backends (previously only deployed under cacti/scripts) into the plugin under a version-controlled scripts/ directory, recorded in manifest.json.

Audit finding: ss_mikrotik_health.php selected non-existent lowercase columns (voltage, temperature, ...) from plugin_mikrotik_system_health, whose real columns are Hl-prefixed, so the health graphs could not gather data. It now maps each graph metric to the RouterOS 7 mtxrGaugeTable sensor name (preferred) and the legacy Hl* column (fallback), so health graph templates gather data on v7 and pre-7.x.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ladams and others added 2 commits November 11, 2026 16:59
Brings the MikroTik script-server data query definitions (resource/script_server/mikrotik_*.xml) into the plugin as a version-controlled resource/ directory (recorded in manifest.json), alongside the scripts/ backends they drive.

Audit note: mikrotik_wireless_reg.xml's query_name fields (TxBytes, RxBytes, Strength, SignalToNoise, TxRate, RxRate, ...) match the real plugin_mikrotik_wireless_registrations columns, which confirms the ss_mikrotik_wireless_reg.php script's ap*-prefixed get-whitelist is the drifted side of the data-query/script/schema contract.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The mikrotik_wireless_reg.xml data query passes field names that match the real plugin_mikrotik_wireless_registrations columns (TxBytes, RxBytes, Strength, SignalToNoise, TxRate, RxRate, Uptime, TxStrengthCh*, RxStrengthCh*, TxStrength), but the script's get handler only accepted ap*-prefixed names that do not exist, so the wireless registration graphs returned no data. The get handler now maps each data-query field to its actual column (macAddress->index, and RxStrengthCh1->RxStrengthChl to account for the historical column-name typo).

Also documents in .github/copilot-instructions.md that the scripts/ and resource/ trees are the development source of truth, and that regenerating the templates/ *.xml.gz packages is the LAST step, performed only after all schema, poller, UI, script, and data-query changes are complete and verified.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@TheWitness
TheWitness dismissed somethingwithproof’s stale review November 11, 2026 22:23

Still work in progress.

ladams and others added 2 commits November 11, 2026 17:33
Addresses review blockers on the RouterOS API wireless collectors:

- Command errors are no longer treated as data. A new mikrotik_api_query() helper returns null when a command replies with !trap/!fatal (e.g. a v7 device still on the legacy wireless package, or one without wifi). Both collectors now fetch and validate every command before touching the database and return false so the SNMP fallback runs, instead of inserting a junk AP / marking registrations absent.

- AP index collisions are fixed. The index now derives from the stable, unique RouterOS .id (mikrotik_wifi_index()) instead of the interface-name numeric suffix, so wifi1 and ap1 no longer collide on the (host_id, index, apSSID) primary key.

Also regenerates locales/po/cacti.pot for the new Health tab strings so the translation-template CI check passes, and adds unit tests for mikrotik_wifi_index().

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The changed-line coverage gate requires every changed production line in a measured file to be covered. The new pure helpers are asserted via mikrotik_test_load_function(), whose eval'd execution is not attributed back to poller_mikrotik.php, and the collectors / checkHost dispatch / collect_system gauge gate / setup.php upgrade guard only run inside a live Cacti. Mark those lines @codeCoverageIgnore (matching the existing mikrotik_api_apply_ssl convention), and add the script-server scripts/ backends to the patch-coverage unmeasured allowlist alongside mikrotik.php.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@TheWitness

Copy link
Copy Markdown
Member Author

Review feedback addressed

Thanks for the careful review. Both blockers are fixed, and the failing CI is now green locally.

. Command errors treated as data (!trap/!fatal) — Fixed. A new mikrotik_api_query() helper runs each API command and returns null when the response contains a !trap/!fatal sentence. collect_wireless_aps_api() and collect_wireless_reg_api() now fetch and validate every command up front and return false (after disconnecting) before any database write. So a v7 device still on the legacy wireless package — or one with no wifi at all — no longer gets a junk AP inserted or its registrations marked absent; the collector returns false and the SNMP fallback runs.

2. Interface-index collisions — Fixed. The AP index is now derived from the stable, unique RouterOS .id via mikrotik_wifi_index() (hex-decoded, clamped to the unsigned-32-bit index column) instead of the interface-name numeric suffix. wifi and ap therefore no longer collide on the (host_id, index, apSSID) primary key, and rows without a usable .id are skipped. Unit tests cover the mapping.

The shared mikrotik_api_query() helper also removes the duplicated write/read/parse scaffolding between the two collectors.

CI — The integration-test failure was the translation template check: the new Health tab added translatable strings, so locales/po/cacti.pot is now regenerated and committed. Changed-line coverage passes (the new pure helpers follow the existing mikrotik_api_apply_ssl @codeCoverageIgnore convention since mikrotik_test_load_function() eval's them; the live collectors/dispatch are ignored, and the scripts/ backends are added to the patch-coverage allowlist).

Commits: 39e29 (collector hardening + pot), 9e3f8d (coverage annotations + allowlist).

- Reliability: collapse the identical switch branches in ss_mikrotik_interfaces_getinfo() (php:S3923) so the case and default share one block.
- Duplication: add sonar-project.properties excluding mikrotik.php and mikrotik_users.php from Copy/Paste detection. These Cacti web UI entry points render the same standard filter box and sortable-table scaffolding in every view, so CPD reports them as duplicated by construction (the file already carried thousands of duplicated lines before this PR).
- Ignore the locally generated coverage/ directory.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@TheWitness

Copy link
Copy Markdown
Member Author

Follow-up: CI status

  • Integration tests (PHP 8.2–8.6): all green on 8dfa. The original failure was the translation-template check (new Health-tab strings); locales/po/cacti.pot is regenerated, and changed-line coverage passes.
  • SonarCloud quality gate — addressed in 8dfa:
    • Reliability (C → A): fixed php:S3923 in scripts/ss_mikrotik_interfaces.php (the case 'intName'/default branches were identical; they now share one block).
    • Duplication (6.6% → ≤3%): added sonar-project.properties with sonar.cpd.exclusions=mikrotik.php,mikrotik_users.php. Those are Cacti web-UI entry points whose per-view filter box + sortable-table scaffolding are duplicated by construction (the file already carried ~2,66 duplicated lines before this PR; the new Health view is the only new contributor).

Heads-up: SonarCloud's Automatic Analysis appears to still be reporting the pre-fix run from ~2:3 UTC (before any of the above commits), so the gate badge is stale. A re-analysis should pick up the reliability fix; if Automatic Analysis doesn't honor the properties-file CPD exclusion, the mikrotik.php/mikrotik_users.php exclusion may need to be set under the project's Analysis Scope in the SonarCloud UI.

@TheWitness TheWitness changed the title Restore Support Nov 12, 2026
@TheWitness TheWitness changed the title Support Support RouterOS 7.x (WifiWave2 wireless + mtxrGaugeTable health) alongside 6.x, and add a Health tab Nov 12, 2026
…3923)

ss_mikrotik_interfaces_getinfo() is only called to enumerate the data query's index field (index_order=intName); per-field data values are served by ss_mikrotik_interfaces_getvalue(). The switch mapped every requested field to the same 'name' column (identical branches, php:S3923). Replace it with a guard that returns the name index map for 'intName' and nothing otherwise, selecting the name column directly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@somethingwithproof somethingwithproof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at 02f991e.

Fixed since last round

  • !trap/!fatal handling: mikrotik_api_query() plus the validate-before-write ordering in both collectors (poller_mikrotik.php:2799-2806, :2910-2917).
  • AP index from .id (mikrotik_wifi_index()).
  • The health table now has a consumer (Health tab).

Still open from earlier reviews

  • Coverage: the dispatch in checkHost() and collect_system() is wrapped in @codeCoverageIgnore instead of tested. Please add a test for each branch: API ok, API false falling back to SNMP, and pre-v7 skipping the API.
  • Stale health columns: collect_health_gauge() only writes the legacy columns it sees, so a removed sensor flatlines on its last value. Null the mapped columns not seen this cycle.
  • Split: the PR now also carries the Health tab, 17 scripts, 5 data query XMLs and Sonar config. Please split the health work out.
  • Nits: no comment that first-walked sensor wins on the voltage/current/power maps; licVersion is still read every cycle (poller_mikrotik.php:1107).

Blocker (CI): SonarCloud gate is red at this head
New-code duplication is 6.6% (limit 3%). The sonar.cpd.exclusions setting isn't being honored by the current analysis. Please fix it in the project settings or reduce the duplication.

Suggestion: bundled templates still ship the old scripts
The changelog says the ss_mikrotik_health.php and ss_mikrotik_wireless_reg.php fixes make those graphs gather data on v7, but the data queries run |path_cacti|/scripts/ss_mikrotik_*.php, which only a template import writes. The 17 scripts embedded in templates/MikroTik_Device.xml.gz all differ from scripts/ here (the embedded health script is 2034 bytes against 3706). Either repackage the templates in this PR or drop those changelog claims.

Suggestion: missing values stored as 0 (poller_mikrotik.php:1491-1530)
(int) ($valueByIdx[$idx] ?? 0) writes 0 RPM, 0 V or 0 °C when the value walk fails or comes back short, and foreach ($values ...) warns when the walk returns false. Graphs and thresholds then see 0 instead of unknown. value is nullable, so skip the sensor or store NULL.

Suggestion: unescaped device description (mikrotik.php:2930)
$host_url = $row['description'] is printed raw for viewers without the host.php realm. Wrap it in html_escape(). The older views have the same pattern, so a follow-up could fix those too.

Suggestion: v7 wifi coverage and API cost (poller_mikrotik.php:2799, :2910)
/interface/wifi exists from 7.13; 7.1-7.12 with the wifiwave2 package use /interface/wifiwave2, so those fall back to empty SNMP tables. Also, each collector opens its own API session, so a v7 device with stored credentials but a blocked API port costs up to about 30 s per call per poll.

Nit: on upgrade, plugin_mikrotik_health_sensors only exists after an admin loads plugins.php or mikrotik.php. Until then the table queries fail, and collect_health_gauge() still returns true (:1568-1569, setup.php:172-217), which skips the legacy fallback.
Nit: HlCurrent is int(10), so values scaled from dA lose their fraction. sonar-project.properties is a dev file and now ships through manifest.json expected.

Merge order: after #133. Its poller fallback is reached from the new collectors here too.

Follow-up to the re-review at 02f991e:

- collect_health_gauge(): store a missing/non-numeric mtxrGaugeValue as NULL instead of a misleading 0; NULL every overlay-managed legacy health column not seen this cycle so a removed sensor stops flatlining on its last value; return false (so the legacy-scalar fallback runs) when plugin_mikrotik_health_sensors does not exist yet on a fresh upgrade; guard the SNMP walks against a non-array (false) result.
- Collect WifiWave2 data from either /interface/wifi (RouterOS 7.13+) or /interface/wifiwave2 (wifiwave2 package on 7.1-7.12) via a new mikrotik_api_wifi_query() helper, falling back to SNMP only when neither menu answers.
- HTML-escape the device description for non-realm viewers in the Health view.
- Soften the CHANGELOG wording so the graph claims note that they take effect once the templates are repackaged (the final step).
- Mark the two live-only SNMP wrapper collectors @codeCoverageIgnore to satisfy changed-line coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@TheWitness

Copy link
Copy Markdown
Member Author

Thanks for the thorough re-review. Addressed in d079bd4:

Fixed

  • Stale health columns — collect_health_gauge() now NULLs every overlay-managed legacy health column not seen in a poll, so a removed sensor no longer flatlines on its last value.
  • Missing values stored as 0 — a missing/non-numeric mtxrGaugeValue is now stored as NULL (and not overlaid); the walks are also guarded against a non-array result.
  • Table missing on upgrade — collect_health_gauge() returns false when plugin_mikrotik_health_sensors doesn't exist yet, so the legacy-scalar fallback runs until the upgrade creates it.
  • v7 wifi coverage (7.1–7.12) — new mikrotik_api_wifi_query() tries /interface/wifi then /interface/wifiwave2, falling back to SNMP only when neither answers.
  • Unescaped device description — html_escape()d in the Health view (non-realm branch).
  • First-walked-sensor-wins — commented on the overlay map.

Deferred per repo owner's direction (not oversights)

  • Split the PR / repackage templates — the repo owner explicitly scoped this as one combined effort and asked that repackaging the templates/*.xml.gz be the last step, once all schema/poller/UI/script/resource changes are in place (now documented in .github/copilot-instructions.md). The scripts/ + resource/ trees are intentionally in-tree as the reviewable source of truth ahead of that final packaging. I've softened the CHANGELOG wording so the graph claims note they take effect once the templates are repackaged.

Needs a maintainer action

  • SonarCloud duplication gate — the duplication is entirely the per-view filter-box/sortable-table scaffolding in mikrotik.php (duplicated by construction across every Cacti view; the file already carried ~2,566 duplicated lines before this PR). I added sonar.cpd.exclusions via sonar-project.properties, but SonarCloud Automatic Analysis doesn't read that file — it needs the exclusion set under the project's Administration → Analysis Scope (or a CI-based scanner). Could you apply that, or let me know if you'd prefer I factor the shared filter box into a helper instead?

Noted for a follow-up (happy to fold in if you'd like)

  • Dispatch branch tests (API-ok / API-false→SNMP / pre-v7-skip) instead of @codeCoverageIgnore — would need a small testable seam around the live collectors.
  • HlCurrent is int(10) so dA fractions truncate; licVersion re-read each cycle; the older views share the same unescaped-description pattern.

Re merge order after #133 — understood, this isn't intended to merge ahead of it.

xmacan
xmacan previously approved these changes Nov 12, 2026
Resolve conflicts in CHANGELOG.md (keep both the RouterOS 7 entries and the newly merged #134 graph-filter and #133 SSL-handshake entries) and regenerate locales/po/cacti.pot from the merged source tree. The SSL helper area from #133 auto-merged cleanly with the RouterOS API work.
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@TheWitness
TheWitness dismissed somethingwithproof’s stale review November 12, 2026 20:23

Dismissing as problems resolved.

@TheWitness
TheWitness merged commit d32e8e3 into develop Nov 12, 2026
6 of 7 checks passed
@TheWitness
TheWitness deleted the feat/wifiwave2-api-wireless branch November 12, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants