Skip to content

fix(api): preserve transport and verify TLS peers by default - #137

Open
somethingwithproof wants to merge 4 commits into
developfrom
fix/preserve-api-transport
Open

somethingwithproof wants to merge 4 commits into
developfrom
fix/preserve-api-transport

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Keep the configured RouterOS API transport after connection failures. Verify TLS certificates and hostnames by default in both the poller and device connection checks; provide an explicit administrator compatibility setting for unverified certificates.

Ref #69. Follow-up to #133 and #135 on develop. Installations using untrusted device certificates need to configure trust or explicitly select the compatibility option.

Validation: 127 tests passed, one skipped. Isolated tests with the real RouterOS client and local servers verify transport preservation, trusted certificates, rejected untrusted certificates, hostname checks and the explicit compatibility option. No live devices were contacted.

Comment thread tests/fixtures/api-tls.php Fixed
xmacan
xmacan previously approved these changes Nov 19, 2026
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants