Repository navigation
fix(api): preserve transport and verify TLS peers by default - #137
Open
somethingwithproof wants to merge 4 commits into
Open
somethingwithproof wants to merge 4 commits into
somethingwithproof wants to merge 4 commits into
Conversation
xmacan
previously approved these changes
Nov 19, 2026
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/preserve-api-transport
branch
from
November 19, 2026 09:31
5d2eb66 to
b94092d
Compare
|
TheWitness
approved these changes
Nov 20, 2026
TheWitness
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Keep the configured RouterOS API transport after connection failures. Verify TLS certificates and hostnames by default in both the poller and device connection checks; provide an explicit administrator compatibility setting for unverified certificates.
Ref #69. Follow-up to #133 and #135 on develop. Installations using untrusted device certificates need to configure trust or explicitly select the compatibility option.
Validation: 127 tests passed, one skipped. Isolated tests with the real RouterOS client and local servers verify transport preservation, trusted certificates, rejected untrusted certificates, hostname checks and the explicit compatibility option. No live devices were contacted.