Skip to content

Set entry number sorting/filtering to correct brapi column name #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jloux-brapi wants to merge 2 commits into
base: feature/BI-3082
Choose a base branch
from
Open

Set entry number sorting/filtering to correct brapi column name #568

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5433ef
Set entry number sorting/filtering to correct brapi column name
jloux-brapi Oct 19, 2026
c5a3665
Continue support of original importEntryNumber, add support for listE…
jloux-brapi Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 13 additions & 38 deletions src/main/java/org/breedinginsight/brapi/v2/model/request/query/GermplasmQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
@Getter
@Introspected
public class GermplasmQuery extends BrapiQuery {
// Actual DB entry number stored in each germplasm.additional_info
private String importEntryNumber;
private String accessionNumber;
private String defaultDisplayName;
Expand All @@ -26,50 +27,15 @@ public class GermplasmQuery extends BrapiQuery {
private String createdDate;
private String createdByUserName;
private String synonym;
// This entry number depicts the sequential order of any given germplasm list.
// To be used only in the use case where listDbId is present and a search request is occurring on a germplasm list.
private String listEntryNumber;
// This is a meta-parameter, it describes the display format of any date fields.
private String dateDisplayFormat;

// The list id used to get a collection of germplasm
private String listDbId;

public SearchRequest constructSearchRequest() {
List<FilterRequest> filters = new ArrayList<>();
if (!StringUtils.isBlank(getImportEntryNumber())) {
filters.add(constructFilterRequest("importEntryNumber", getImportEntryNumber()));
}
if (!StringUtils.isBlank(getAccessionNumber())) {
filters.add(constructFilterRequest("accessionNumber", getAccessionNumber()));
}
if (!StringUtils.isBlank(getDefaultDisplayName())) {
filters.add(constructFilterRequest("defaultDisplayName", getDefaultDisplayName()));
}
if (!StringUtils.isBlank(getBreedingMethod())) {
filters.add(constructFilterRequest("breedingMethod", getBreedingMethod()));
}
if (!StringUtils.isBlank(getSeedSource())) {
filters.add(constructFilterRequest("seedSource", getSeedSource()));
}
if (!StringUtils.isBlank(getPedigree())) {
filters.add(constructFilterRequest("pedigree", getPedigree()));
}
if (!StringUtils.isBlank(getFemaleParentGID())) {
filters.add(constructFilterRequest("femaleParentGID", getFemaleParentGID()));
}
if (!StringUtils.isBlank(getMaleParentGID())) {
filters.add(constructFilterRequest("maleParentGID", getMaleParentGID()));
}
if (!StringUtils.isBlank(getCreatedDate())) {
filters.add(constructFilterRequest("createdDate", getCreatedDate()));
}
if (!StringUtils.isBlank(getCreatedByUserName())) {
filters.add(constructFilterRequest("createdByUserName", getCreatedByUserName()));
}
if (!StringUtils.isBlank(getSynonym())) {
filters.add(constructFilterRequest("synonyms", getSynonym()));
}
return new SearchRequest(filters);
}

@Override
public Map<String, String> getFilterValuesByBrAPIColumnName() {
Map<String, String> filterValuesByBrAPIColumnName = new HashMap<>();
Expand All @@ -86,6 +52,10 @@ public Map<String, String> getFilterValuesByBrAPIColumnName() {
filterValuesByBrAPIColumnName.put("createdBy", getCreatedByUserName());
filterValuesByBrAPIColumnName.put("synonyms", getSynonym());

if (!StringUtils.isBlank(listDbId)) {
filterValuesByBrAPIColumnName.put("listItemPosition", getListEntryNumber());
}

return filterValuesByBrAPIColumnName;
}

Expand All @@ -105,6 +75,11 @@ public Map<String, String> getBrAPIColumnNamesByBiColumnName() {
brAPIColumnNamesByBiColumnName.put("createdByUserName", "createdBy");
brAPIColumnNamesByBiColumnName.put("synonyms", "synonyms");

if (!StringUtils.isBlank(listDbId)) {
brAPIColumnNamesByBiColumnName.put("listEntryNumber", "listItemPosition");
}


return brAPIColumnNamesByBiColumnName;
}
}
Loading