Skip to content

Set entry number sorting/filtering to correct brapi column name - #568

Open
jloux-brapi wants to merge 2 commits into
feature/BI-3082from
feature/BI-3089
Open

jloux-brapi wants to merge 2 commits into
feature/BI-3082from
feature/BI-3089

Conversation

@jloux-brapi

@jloux-brapi jloux-brapi commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Story: BI-3089

Set entry number sorting/filtering to correct brapi column name

Dependencies

Testing

On a program that has Germplasm imported, Open a Germplasm List Show Details page.

  • Verify Entry Number column has is sortable and filterable, and works as expected.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

Map<String, String> brAPIColumnNamesByBiColumnName = new HashMap<>();

brAPIColumnNamesByBiColumnName.put("importEntryNumber", "importEntryNumber");
brAPIColumnNamesByBiColumnName.put("importEntryNumber", "listItemPosition");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GermplasmQuery is shared by both list and non-list germplasm searches, but this always maps importEntryNumber to the list-only listItemPosition field. When listDbId is absent, the standard germplasm endpoint still expects importEntryNumber and will reject listItemPosition. Could this mapping be conditional on listDbId, or can we confirm that non-list requests using this sort field are intentionally unsupported?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a big concern for the data tables, but for the search endpoints previously we added support for sorting on the actual importEntryNumber and now it has been removed.

I reverted changes to support the regular importEntryNumber and added a new field, ListEntryNumber, and reflected these changes also on the bi-web side too, so those changes should be reviewed again as well.

@humsika humsika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me and everything is working as expected.

@humsika humsika added the on hold Review, but do not merge until removed label Oct 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature on hold Review, but do not merge until removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants