Repository navigation
Set entry number sorting/filtering to correct brapi column name - #568
jloux-brapi wants to merge 2 commits into
Conversation
| Map<String, String> brAPIColumnNamesByBiColumnName = new HashMap<>(); | ||
|
|
||
| brAPIColumnNamesByBiColumnName.put("importEntryNumber", "importEntryNumber"); | ||
| brAPIColumnNamesByBiColumnName.put("importEntryNumber", "listItemPosition"); |
There was a problem hiding this comment.
GermplasmQuery is shared by both list and non-list germplasm searches, but this always maps importEntryNumber to the list-only listItemPosition field. When listDbId is absent, the standard germplasm endpoint still expects importEntryNumber and will reject listItemPosition. Could this mapping be conditional on listDbId, or can we confirm that non-list requests using this sort field are intentionally unsupported?
There was a problem hiding this comment.
I don't think this is a big concern for the data tables, but for the search endpoints previously we added support for sorting on the actual importEntryNumber and now it has been removed.
I reverted changes to support the regular importEntryNumber and added a new field, ListEntryNumber, and reflected these changes also on the bi-web side too, so those changes should be reviewed again as well.
humsika
left a comment
There was a problem hiding this comment.
Code looks good to me and everything is working as expected.
Description
Story: BI-3089
Set entry number sorting/filtering to correct brapi column name
Dependencies
Testing
On a program that has Germplasm imported, Open a Germplasm List
Show Detailspage.Entry Numbercolumn has is sortable and filterable, and works as expected.Checklist: