Repository navigation
feat(query): expose truncation and row-cap metadata - #6
efegokdemir wants to merge 1 commit into
Conversation
jallegri
left a comment
There was a problem hiding this comment.
Reviewed against Arc#726: the model exposes both signals with backward-compatible defaults, preserves the distinction between failed/truncated results and valid policy-capped results, and QueryClient.query() validates the decoded response through this model. I found no code-blocking issues. The PR description reports 103 passing unit tests plus Ruff and mypy. The current GitHub CI run is action_required with no jobs, so the CI result is still outstanding before merge; this review does not treat the author-reported local checks as CI evidence.
|
Residual transport work tracked in #9; overall parity analysis: https://github.com/Basekick-Labs/ops/issues/40. This PR covers JSON/model fields. PR #2's MessagePack decoder reconstructs QueryResponse without |
|
Closing as superseded: |
What changed
Expose Arc's
truncated,truncation_reason,rows_cappedandrow_capresponse fields onQueryResponse, and document how to distinguish failed/truncated results from results limited by policy.Older servers remain compatible: missing fields default to
FalseorNone.Testing
uv run pytest tests/unit -q --tb=short(103 passed)uv run ruff check .uv run ruff format --check .uv run mypy src/arc_client --ignore-missing-importsThe regression test failed before adding the model fields and passes with this change.
Related: Basekick-Labs/arc#726