Repository navigation
[eno] Prune input revisions for refs removed from the synthesizer - #673
Draft
Ruinan Liu (ruinan-liu) wants to merge 1 commit into
Draft
Ruinan Liu (ruinan-liu) wants to merge 1 commit into
Ruinan Liu (ruinan-liu) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes Eno being unable to resynthesize after a synthesizer removes a ref.
Problem
• The pruning controller kept any input revision whose key still had a Composition binding, even after the synthesizer removed the ref. Bindings inherited from a Symphony keep it there.
• That leftover revision stops being updated. If it carries eno.azure.io/synthesizer-generation or eno.azure.io/revision , the Composition stays out of lockstep ( MismatchedInputs ) and never resynthesizes.
• The pruner only watched Compositions, so a synthesizer change didn't trigger pruning directly.
Changes
• A revision is now kept only if the synthesizer still declares the ref and it is bound, either by a Composition binding or by the ref naming its own resource.
• All leftover revisions are removed in a single status update.
• Nothing is pruned when the synthesizer is missing.
• The pruning controller now watches Synthesizers and requeues their Compositions.
Tests
• Unit tests for isInputBound and the pruner's Reconcile ( pruning_test.go ).
• Integration test: a removed ref with its binding still present is pruned, and adding the ref back restores the revision.
• E2E test TestSynthesizerInputRemoval : two inputs, one ref removed, then a new synthesis that outputs only the remaining input.