Skip to content

test: drop the forwarding case from test_proxy_https_target_tls_error (stale after CVE-2026-97687) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icanhasmath merged 1 commit into from
Oct 28, 2026
Merged

test: drop the forwarding case from test_proxy_https_target_tls_error (stale after CVE-2026-97687) #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/with_dummyserver/test_proxy_poolmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,9 +738,15 @@ def test_https_proxy_tls_error(self, target_scheme, use_forwarding_for_https):
@pytest.mark.parametrize(
["proxy_scheme", "use_forwarding_for_https"],
[
# No ("https", True) case: when forwarding, the client never makes
# a TLS connection to the target, so the target's ssl_context
# cannot cause a TLS error. The error this case expected came
# from applying the target's TLS settings to the proxy
# connection, which is CVE-2026-97687 (fixed in 1.26.20.post3).
# Upstream skipped this case as urllib3/urllib3#2577 and removed
# it with the fix in 2.8.0.
("http", False),
("https", False),
("https", True),
],
)
def test_proxy_https_target_tls_error(self, proxy_scheme, use_forwarding_for_https):
Expand Down
Loading