Repository navigation
test: drop the forwarding case from test_proxy_https_target_tls_error (stale after CVE-2026-97687) - #6
Merged
Conversation
test_proxy_https_target_tls_error[https-True] expected an SSLError when forwarding an HTTPS request through an HTTPS proxy with a target ssl_context that trusts nothing. When forwarding, the client never makes a TLS connection to the target, so that error only happened because the target's TLS settings were applied to the proxy connection: CVE-2026-97687, fixed in 1.26.20.post3. Since then the case fails ("DID NOT RAISE") on Python 3.9 and 3.10. Upstream skipped this case as urllib3#2577 (2.7.0) and removed it together with the CVE-2026-97687 fix in 2.8.0. Remove it here too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ezequielp-activestate
approved these changes
Oct 28, 2026
ezequielp-activestate
left a comment
ezequielp-activestate
left a comment
There was a problem hiding this comment.
No blockers. In python:3.10-slim with tornado 6.1 and trustme, test/with_dummyserver/test_proxy_poolmanager.py gives 1 failed, 49 passed, 3 skipped on 1.26.20.x. The failure is test_proxy_https_target_tls_error[https-True]. On this branch it gives 49 passed, 3 skipped. Upstream matches the description: 2.7.0 skips that case with pytest.skip("... urllib3/urllib3#2577"), and 2.8.0 parametrizes the test on proxy_scheme only, with no forwarding case. On Python 2.7 the HTTPS-proxy cases are skipped on both branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only change. No release needed.
test_proxy_https_target_tls_error[https-True]fails on Python 3.9 and 3.10 withDID NOT RAISE MaxRetryErrorsince 1.26.20.post3:ssl_contextthat trusts nothing, and expects an SSLError.I found this while running the urllib3 suite on 3.9 and 3.10 for ActiveState/pip#15, which vendors 1.26.20.post4. In
python:3.10-slim,test_proxy_poolmanager.pynow gives 47 passed and 3 skipped. The twotest_tunneling_proxy_request_timeoutfailures also happen on upstream 1.26.20 in that container.