Repository navigation
fix(json-format): render large JSON after result state is ready - #671
Closed
Souvenirser wants to merge 2 commits into
Closed
Souvenirser wants to merge 2 commits into
Souvenirser wants to merge 2 commits into
Conversation
Exercise the real page and Formatter with long text, node-budget input, small JSON, view transitions, invalid input and auto-decode. Preserve the synchronous boolean return contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large valid JSON could leave the result pane blank because the page called Formatter before enabling result actions. The large JSON text view renders synchronously and was rejected by the existing rendering guard. Initialize the successful result state before formatting, and clear and hide the previous text view when showing a placeholder or error.
Validation:
No dependency changes or original sample data are included.