Indicate to the client if incoming packets were APS encrypted - #61
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Adds an APS-encryption indicator to incoming packet notifications while preserving the existing wire payload size and protocol version.
Changes:
- Replaces a reserved bit with
aps_encrypted. - Propagates encryption status through parsing, notifications, and wire encoding.
File summaries
| File | Description |
|---|---|
crates/ziggurat-protocol/src/wire.rs |
Adds the wire-level encryption flag. |
crates/ziggurat-protocol/src/bridge.rs |
Encodes the flag in notifications. |
crates/ziggurat-driver/src/zigbee_stack.rs |
Detects and propagates APS encryption status. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
puddly
force-pushed
the
puddly/aps-encrypted-flag
branch
from
September 17, 2026 20:30
f6ea55e to
bba8c3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses one of our reserved bits (six left 😄) to indicate if an incoming packet was APS encrypted. I don't think we need to bump
PROTOCOL_VERSIONhere.