Pass through the APS encryption flag on incoming packets - #754
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is focused, consistent with existing mappings, and adequately tested.
Pull request overview
Passes APS encryption state from incoming Ember APS frames into ZigbeePacket.tx_options, enabling encrypted replies.
Changes:
- Maps APS encryption flags to
TransmitOptions.APS_Encryption. - Adds parameterized unicast coverage for encrypted and unencrypted packets.
File summaries
| File | Description |
|---|---|
bellows/zigbee/application.py |
Propagates APS encryption metadata. |
tests/test_application.py |
Tests encryption flag propagation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #754 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 64 64
Lines 4269 4272 +3
=======================================
+ Hits 4250 4253 +3
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bellows does not currently pass through any TX options flags for incoming packets. APS encryption (automatically decrypted by the NCP) is useful to know.
Related to zigpy/zigpy#1889.