Repository navigation
ci(lint): pin zsh-lint v1.5.0 - #45
Merged
Merged
Conversation
ss-o
commented
Oct 16, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: maintainer elected after the Copilot request did not register, on d894c65
Findings
No actionable findings. The one-line diff moves the zsh-lint checkout ref from v1.4.0 (aff6018) to the signed v1.5.0 tag's commit b3b9fdc, with its version comment; the Go version still comes from the analyzer's go.mod, and the build and lint steps are unchanged.
Checklist verdicts
- Pin: pass.
b3b9fdce3799827755ae546d2185e3d85063e6dbis the commit the v1.5.0 tag points to. - Behavior: pass. With
zsh-lint.json, v1.4.0 and v1.5.0 both report no findings onbuild.zshand exit 0. - Checks: pass. actionlint passes locally and all 9 hosted checks pass on this head; the commit signature is verified.
This is an author-side review of record, not independent human approval. No threads or comments were open at publication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Zsh lint job from zsh-lint v1.4.0 to v1.5.0.
Part of z-shell/zsh-lint#612. zsh-lint v1.5.0: https://github.com/z-shell/zsh-lint/releases/tag/v1.5.0 (signed tag on
b3b9fdc). The analyzer now builds as one root module and needs Go 1.27, which this workflow already reads from the analyzer's owngo.mod.Verification
zsh-lint.json, v1.4.0 and v1.5.0 both report no findings onbuild.zshand exit 0.trunk check --no-fix --ci(actionlint) passes on the workflow.This repository's Renovate configuration includes the zsh-lint preset, but Renovate has not opened a dashboard or pull request here, so the repin is manual.