Skip to content

ci(lint): pin zsh-lint v1.5.0 - #45

Merged
ss-o merged 1 commit into
mainfrom
ci/zsh-lint-1-5-0
Oct 16, 2026
Merged

ss-o merged 1 commit into
mainfrom
ci/zsh-lint-1-5-0

Conversation

@ss-o

@ss-o ss-o commented Oct 16, 2026

Copy link
Copy Markdown
Member

Moves the Zsh lint job from zsh-lint v1.4.0 to v1.5.0.

Part of z-shell/zsh-lint#612. zsh-lint v1.5.0: https://github.com/z-shell/zsh-lint/releases/tag/v1.5.0 (signed tag on b3b9fdc). The analyzer now builds as one root module and needs Go 1.27, which this workflow already reads from the analyzer's own go.mod.

Verification

  • With zsh-lint.json, v1.4.0 and v1.5.0 both report no findings on build.zsh and exit 0.
  • trunk check --no-fix --ci (actionlint) passes on the workflow.

This repository's Renovate configuration includes the zsh-lint preset, but Renovate has not opened a dashboard or pull request here, so the repin is manual.

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback review under ADR-0026: maintainer elected after the Copilot request did not register, on d894c65

Findings

No actionable findings. The one-line diff moves the zsh-lint checkout ref from v1.4.0 (aff6018) to the signed v1.5.0 tag's commit b3b9fdc, with its version comment; the Go version still comes from the analyzer's go.mod, and the build and lint steps are unchanged.

Checklist verdicts

  • Pin: pass. b3b9fdce3799827755ae546d2185e3d85063e6db is the commit the v1.5.0 tag points to.
  • Behavior: pass. With zsh-lint.json, v1.4.0 and v1.5.0 both report no findings on build.zsh and exit 0.
  • Checks: pass. actionlint passes locally and all 9 hosted checks pass on this head; the commit signature is verified.

This is an author-side review of record, not independent human approval. No threads or comments were open at publication.

@ss-o
ss-o merged commit 497df91 into main Oct 16, 2026
9 checks passed
@ss-o
ss-o deleted the ci/zsh-lint-1-5-0 branch October 16, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant