Skip to content

ci(contract): run detector tests only when the commits change (#654) #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ss-o merged 1 commit into from
Oct 15, 2026
Merged

ci(contract): run detector tests only when the commits change (#654) #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/public-contract-impact.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ on:
# one without). The cancelled check runs for required contexts then kept a
# pull request blocked while the same contexts had passed (#594). Letting a
# superseded run finish costs seconds; a cancelled run can block a merge.
#
# The policy comparison reruns on every event because the pull request body
# and labels are its inputs. The detector tests depend only on the base and
# head commits, so they run only when those can change (#654).

permissions:
contents: read
Expand Down Expand Up @@ -65,14 +69,17 @@ jobs:
run: zsh "$TRUSTED_ROOT/scripts/public-contract-impact.zsh" --base "$BASE_SHA" --head "$HEAD_SHA" ${POLICY_ARG:+"$POLICY_ARG"}

- name: Test trusted public contract detector
if: steps.detector.outputs.has_trusted_tests == 'true'
if: >-
steps.detector.outputs.has_trusted_tests == 'true' &&
contains(fromJSON('["opened", "synchronize", "reopened"]'), github.event.action)
env:
TRUSTED_ROOT: ${{ steps.detector.outputs.root }}
run: cd "$TRUSTED_ROOT" && zsh tests/public-contract-impact.zsh

detector-head-tests:
name: Public contract detector tests
needs: contract-impact
if: contains(fromJSON('["opened", "synchronize", "reopened"]'), github.event.action)
runs-on: ubuntu-latest
steps:
- name: Check out pull request head
Expand Down
Loading