Repository navigation
docs(zsh-lint): sync generated reference - #947
Conversation
Deploying zsh with
|
| Latest commit: |
41ff136
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://efb042a5.zsh.pages.dev |
| Branch Preview URL: | https://docs-zsh-lint-reference.zsh.pages.dev |
ebed6f3 to
41ff136
Compare
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on 41ff136
Sole-maintainer exception
The maintainer elected the ADR-0035 sole-maintainer exception for this pull request at head 41ff136. No second human reviewer is available, and the configured Copilot request on this head did not register (requested 2026-10-19T17:51:21Z, no review_requested event for Copilot; cause unconfirmed). A new head voids this election and this review.
Findings
No actionable findings.
Scope: the complete diff from main at aa3e736 to 41ff136: one generated file, community/04_zsh_lint/08_rule_reference.mdx, produced by the zsh-lint reference sync from the published v1.6.0 release (z-shell/zsh-lint commit f634124).
Note
This fallback review and the exact-head review below are not a human review or an approval to merge.
Exact-head read-only review
A read-only exact-head review of this commit, in its own reviewing session using the organization code-review checklist, reported no actionable findings. Its evidence:
- Every hunk lies inside the
zsh-lint:generatedmarkers (lines 21 and 523). Frontmatter and hand-written text are byte-identical tomain. - The provenance notice names
v1.6.0, commitf634124, andgo install ...@v1.6.0. - All 16 rules with an ID in
internal/rulesat the tag appear once in the list and once as a heading, and the anchors resolve. The one addition isplugin/project-unload-lifecycle; every rule onmainkeeps its ID. - Six rule bodies match their Go doc comments word for word:
plugin/project-unload-lifecycle,plugin/unload-function,quoting/unquoted-var,compat/special-param-shadow,security/evalandplugin/zero-handling. - There is no unescaped
<,>,{or}outside code.\*\_functions,\*.plugin.zshandzle-\*are escaped literals, and every fence declareszsh.scripts/validate-frontmatter.mjsandscripts/validate-code-fences.mjspass. - Unavailable there: a full Docusaurus build, because that read-only session had no installed dependencies.
Validation
- Passed on the head: every pull-request check, including Branch Name, Issue Link, PR Title, Commits, Trunk Code Quality, CodeQL, Org Routing, Validate Corpus and the Cloudflare Pages preview build, which compiles the MDX.
- Reproduced for this review: the hunk list stays between lines 24 and 415 of the generated region, the 16 rule headings equal the 16
ID:lines in thev1.6.0sources, and no heading onmainis missing from the head.
Checklist verdicts and supporting evidence
- Scope and ownership: pass. Only the generated region changed, and the zsh-lint sync workflow owns it. Hand-edits there would be overwritten by the next sync.
- Correctness: pass. The reference matches the published
v1.6.0sources rule for rule. It replaces thev1.3.0reference thatmainstill showed. - Rendering: pass. The preview build compiled the page, the MDX hazards are escaped, and the fences are labelled.
- Traceability: pass. The body references z-shell/zsh-lint#743, the pull request that produced the tag commit, and the provenance notice links the exact source commit.
- Supply chain and deployment: pass. The commit is a verified signed commit from the wiki sync app. The change is content only, with no dependency, workflow or configuration change.
Limits and recovery
- Unavailable: a full local Docusaurus build. The Cloudflare Pages preview build on this head is the build evidence.
- Recovery: if the deployed page renders incorrectly after merge, revert the squash commit on
main. The previousv1.3.0reference then returns until the sync's next run produces a corrected pull request.
Automated reference sync from
z-shell/zsh-lint.Generated from published rule documentation. Do not hand-edit the marked region.
Published source: v1.6.0
Source commit: f6341241c398fd2a784452e75895dafb06186bbc
Refs z-shell/zsh-lint#743