Skip to content

docs(agents): align the branch-name rule with commit-lint - #945

Merged
ss-o merged 1 commit into
mainfrom
feature-944
Oct 19, 2026
Merged

ss-o merged 1 commit into
mainfrom
feature-944

Conversation

@ss-o

@ss-o ss-o commented Oct 19, 2026

Copy link
Copy Markdown
Member

Summary

Closes #944. AGENTS.md listed only feature, bug and hotfix issue branches, but this repository's commit-lint.yml calls the organization workflow with its default BRANCH_PATTERN, which also accepts an optional -<slug> and <type>/<slug>. The rule now states the enforced pattern and links the pull-request runbook.

  • Also updates the published contributor guide (community/00_contributing/01_getting_started.mdx, "Branch naming"), which AGENTS.md cites.

Verification

  • The caller pins z-shell/.github/.github/workflows/commit-lint.yml with no branch-pattern input; the default there accepts both forms.
  • Trunk on the changed files: no issues; the commit hooks passed.
  • Not run locally: pnpm validate:code-fences and pnpm build:en (no node_modules in the worktree); the edited code block keeps its text language, and CI builds the site.

Agent handoff

No handoff needed.

Closes #944. The rule listed only feature, bug and hotfix issue branches, while the commit-lint caller enforces the organization pattern, which also accepts an optional slug and <type>/<slug>; the text now links the pull-request runbook.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Deploying zsh with  Cloudflare Pages  Cloudflare Pages

Latest commit: b7a1237
Status: ✅  Deploy successful!
Preview URL: https://535aa31a.zsh.pages.dev
Branch Preview URL: https://feature-944.zsh.pages.dev

View logs

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback review under ADR-0026: Copilot request not registered on b7a1237

Findings

No actionable findings.

Scope: the full diff of this head (AGENTS.md, community/00_contributing/01_getting_started.mdx), closes #944.

Important

ADR-0035 sole-maintainer exception. On 2026-10-19 the maintainer declared that no second human reviewer is available and explicitly elected the exception for this pull request at head b7a12371465eb1aff650c06e41b4383049fdbb70. Copilot review is configured for main; one request was made after CI passed and did not register (no review_requested event on the timeline). A new head voids this election and this review.

Note

This review is by the authoring agent (a Claude model). It is not an independent human review and not approval to merge or deploy.

Separate read-only review

A separate Codex session (requested model gpt-6-astra, high effort; ws delegation 1ef620eb-6a54-4051-9fae-d53d829c6d88) reviewed the same head read-only and reported no findings: the commit-lint.yml caller pins the organization workflow with no branch-pattern input, the changed text matches that workflow's default pattern and is consistent across the changed files, and the changed Markdown is valid. It changed no files. Automated review is additional scrutiny, not a second human.

Validation

  • Passed: PR checks on this head: 12 success. Locally: Trunk on the changed files; the commit hooks passed.
  • Gaps: full MDX compilation and pnpm build:en did not run locally (no node_modules; the separate review also found the package store read-only); node scripts/validate-code-fences.mjs passed in the separate review, and CI built the site on this head.
Checklist verdicts and supporting evidence
  • Documentation accuracy: pass. The rule now states the enforced pattern and links the pull-request runbook; the reusable workflow at the pinned revision accepts both forms.
  • Supply chain, deployment and failure paths: not affected. Documentation only; no workflow, dependency or build change.
  • Recovery plan: revert the squash commit on main if the text proves wrong; nothing else depends on it.

@ss-o
ss-o merged commit aa3e736 into main Oct 19, 2026
12 checks passed
@ss-o
ss-o deleted the feature-944 branch October 19, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: align the branch-name rule with the enforced commit-lint pattern

1 participant