Repository navigation
docs(agents): align the branch-name rule with commit-lint - #945
Conversation
Closes #944. The rule listed only feature, bug and hotfix issue branches, while the commit-lint caller enforces the organization pattern, which also accepts an optional slug and <type>/<slug>; the text now links the pull-request runbook.
Deploying zsh with
|
| Latest commit: |
b7a1237
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://535aa31a.zsh.pages.dev |
| Branch Preview URL: | https://feature-944.zsh.pages.dev |
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on b7a1237
Findings
No actionable findings.
Scope: the full diff of this head (AGENTS.md, community/00_contributing/01_getting_started.mdx), closes #944.
Important
ADR-0035 sole-maintainer exception. On 2026-10-19 the maintainer declared that no second human reviewer is available and explicitly elected the exception for this pull request at head b7a12371465eb1aff650c06e41b4383049fdbb70. Copilot review is configured for main; one request was made after CI passed and did not register (no review_requested event on the timeline). A new head voids this election and this review.
Note
This review is by the authoring agent (a Claude model). It is not an independent human review and not approval to merge or deploy.
Separate read-only review
A separate Codex session (requested model gpt-6-astra, high effort; ws delegation 1ef620eb-6a54-4051-9fae-d53d829c6d88) reviewed the same head read-only and reported no findings: the commit-lint.yml caller pins the organization workflow with no branch-pattern input, the changed text matches that workflow's default pattern and is consistent across the changed files, and the changed Markdown is valid. It changed no files. Automated review is additional scrutiny, not a second human.
Validation
- Passed: PR checks on this head: 12 success. Locally: Trunk on the changed files; the commit hooks passed.
- Gaps: full MDX compilation and
pnpm build:endid not run locally (nonode_modules; the separate review also found the package store read-only);node scripts/validate-code-fences.mjspassed in the separate review, and CI built the site on this head.
Checklist verdicts and supporting evidence
- Documentation accuracy: pass. The rule now states the enforced pattern and links the pull-request runbook; the reusable workflow at the pinned revision accepts both forms.
- Supply chain, deployment and failure paths: not affected. Documentation only; no workflow, dependency or build change.
- Recovery plan: revert the squash commit on
mainif the text proves wrong; nothing else depends on it.
Summary
Closes #944.
AGENTS.mdlisted onlyfeature,bugandhotfixissue branches, but this repository'scommit-lint.ymlcalls the organization workflow with its defaultBRANCH_PATTERN, which also accepts an optional-<slug>and<type>/<slug>. The rule now states the enforced pattern and links the pull-request runbook.community/00_contributing/01_getting_started.mdx, "Branch naming"), whichAGENTS.mdcites.Verification
z-shell/.github/.github/workflows/commit-lint.ymlwith nobranch-patterninput; the default there accepts both forms.pnpm validate:code-fencesandpnpm build:en(nonode_modulesin the worktree); the edited code block keeps itstextlanguage, and CI builds the site.Agent handoff
No handoff needed.