Repository navigation
docs(ci): handle CodeQL unpinned-tag alerts on @main callers (#809) - #810
Merged
Merged
Conversation
ss-o
commented
Oct 16, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: maintainer elected after the Copilot request did not register, on fd7313b
Findings
No actionable findings in the three-file diff against main.
Checklist verdicts
- Scope: pass. The contract gains one Action Pinning rule and one checklist item; the generated instruction matches its source (
knowledge-delivery.py --check). ADR-0042 gains one Consequences bullet; its decision, status, deciders and acceptance are unchanged. - Accuracy: pass. The rule matches what happened in zsh-lint PR 699: CodeQL
actions/unpinned-tag(code-scanning alert 16) arrived as a review thread on the@maincaller and was cleared by a reply citing ADR-0042, a "won't fix" dismissal and thread resolution. The dismissal is limited toz-shell/.github/.github/workflows/*@mainreferences, so third-party and organization-action pins are still reported. The claim that default setup cannot filter queries holds: default setup takes no configuration file, and 57 of 94 unarchived repositories use it for Actions. - Links: pass. The ADR's relative link resolves to
knowledge/domains/ci/workflow-contract.md, and the issue link points to #809. - Verification: pass. All seven organization validators and 339 unit tests pass locally; whitespace and Trunk pass on the three files; all 12 hosted checks pass on this head, and the commit signature is verified.
This is an author-side review of record, not independent human approval. No threads or comments were open at publication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knowledge/domains/ci/workflow-contract.mdand generated.github/instructions/ci/workflow-contract.instructions.md): a new Action Pinning rule says that CodeQL'sactions/unpinned-tagquery reports@mainreferences to organization reusable workflows. When a caller moves, the alert arrives as a review thread that blocks merge, and it is handled by replying with the ADR-0042 reason, dismissing it as "won't fix" and resolving the thread. Only alerts onz-shell/.github/.github/workflows/*@mainare dismissed; any otheractions/unpinned-tagalert stays a defect to fix. The pre-merge checklist gains the matching item.Closes #809
Impact review
main, so nothing is regenerated or repinned downstream.knowledge-delivery.py --checkpasses for 57 consumers.Verification
knowledge-delivery.py --check,knowledge-coverage.py,decision-records.py --check,validate-agent-policy.py,org-routing.py validate,org-routing.py verify-approvedandvalidate-zsh-standard-policy.pypass.git diff --checkandtrunk check --no-fix --cion the three files pass.Agent handoff
No handoff needed.